Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvclive 1.0 #4085

Merged
merged 71 commits into from
Nov 5, 2022
Merged

dvclive 1.0 #4085

merged 71 commits into from
Nov 5, 2022

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Oct 28, 2022

Changes from iterative/dvclive#223

@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-1-0-tvslhct0gi November 4, 2022 18:01 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-1-0-tvslhct0gi November 4, 2022 18:24 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-1-0-tvslhct0gi November 4, 2022 18:27 Inactive
@rogermparent rogermparent temporarily deployed to dvc-org-dvclive-1-0-tvslhct0gi November 4, 2022 18:36 Inactive
@rogermparent
Copy link
Contributor

rogermparent commented Nov 4, 2022

I just pulled main into the branch, hopefully that helps things out. I just pushed it in here because we can't confirm without a deploy and we'd need to merge main at some point anyway. The dvc-based images can freak out if they're not updated.

@dberenbaum
Copy link
Contributor

I just pulled main into the branch, hopefully that helps things out. I just pushed it in here because we can't confirm without a deploy and we'd need to merge main at some point anyway. The dvc-based images can freak out if they're not updated.

Thanks @rogermparent! Still looks broken to me ☹️ . Any idea on whether we should expect it to work in prod?

@rogermparent
Copy link
Contributor

Any idea on whether we should expect it to work in prod?

I have no idea, maybe so if it's a simple cache issue. I'll spin up another fresh branch and see.

@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-1-0-cop-7v0oe6 November 4, 2022 18:48 Inactive
@rogermparent rogermparent mentioned this pull request Nov 4, 2022
@restyled-io restyled-io bot mentioned this pull request Nov 4, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-1-0-tvslhct0gi November 4, 2022 19:03 Inactive
@rogermparent
Copy link
Contributor

rogermparent commented Nov 4, 2022

image
The copy works!
My working theory is that either this PR's copy of the cache or this PR's S3 got desynchronized from main's, and it was expecting images to exist where they actually didn't.

As for if this will work on main, I'm pretty sure it should. New branches grab cache from main, so the build on main should be fine just like the new branch. Sorry for the inconvenience!

@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-1-0-tvslhct0gi November 4, 2022 19:06 Inactive
@dberenbaum
Copy link
Contributor

Thanks @rogermparent! I guess we can keep an eye on it and revert if needed.

@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-1-0-tvslhct0gi November 4, 2022 19:12 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-dvclive-1-0-tvslhct0gi November 4, 2022 19:58 Inactive
@daavoo daavoo removed the ⌛ status: wait-core-merge Waiting for related product PR merge/release label Nov 5, 2022
@daavoo daavoo merged commit 4c3c1ff into main Nov 5, 2022
@daavoo daavoo deleted the dvclive-1.0 branch November 5, 2022 10:17
@jorgeorpinel
Copy link
Contributor

https://github.com/iterative/example-get-started and https://github.com/iterative/example-dvc-experiments need to be updated.

What's the plan on this? Esp. with the work on a new example repo

Thanks

@daavoo
Copy link
Contributor Author

daavoo commented Nov 22, 2022

What's the plan on this? Esp. with the work on a new example repo

Both are already updated and the new example repo is also using the latest version of DVCLive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: dvclive Content of /doc/dvclive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants