data status: exclude remote status by default #9411
Conversation
| @@ -402,15 +402,23 @@ def test_missing_remote_cache(M, tmp_dir, dvc, scm, local_remote): | |||
| tmp_dir.dvc_gen({"dir": {"foo": "foo", "bar": "bar"}}) | |||
| tmp_dir.dvc_gen("foobar", "foobar") | |||
|
|
|||
| assert dvc.data_status(untracked_files="all") == { | |||
There was a problem hiding this comment.
@efiop Do we have a way to test remote refresh?
There was a problem hiding this comment.
Not really and I don't think we need to.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9411 +/- ##
==========================================
- Coverage 91.61% 91.60% -0.01%
==========================================
Files 487 487
Lines 37778 37780 +2
Branches 5436 5436
==========================================
Hits 34610 34610
- Misses 2612 2614 +2
Partials 556 556
☔ View full report in Codecov by Sentry. |
|
For the record: some questions in #9410 (comment) |
| help="Show files not in remote.", | ||
| ) | ||
| data_status_parser.add_argument( | ||
| "--no-remote-refresh", |
There was a problem hiding this comment.
@efiop I think refreshing is a more reasonable default because it is probably more intuitive and expected unless users are thinking deeply about how it compares to git. However, if you have a reason why you strongly prefer to rely on the index by default, I'm open to changing this back as long as we also keep the --not-in-remote option.
There was a problem hiding this comment.
If it's an explicit flag, fetching latest changes make sense to me. I'm okay with showing a hint/summary to dvc push if needed by default.
Fixes #9410.
Needs a docs PR.
Before this PR:
After this PR: