Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data status: do not show "not in remote" status by default #9410

Closed
skshetry opened this issue May 5, 2023 · 6 comments · Fixed by #9411
Closed

data status: do not show "not in remote" status by default #9410

skshetry opened this issue May 5, 2023 · 6 comments · Fixed by #9411
Labels
A: cli Related to the CLI p1-important Important, aka current backlog of things to do

Comments

@skshetry
Copy link
Member

skshetry commented May 5, 2023

As I have been playing with virtual operations, the fact that data status shows "Not in remote" statuses of files has really started bothering me. Couple that with data status not supporting filtering to sub-paths, it's extremely noisy.

A command meant for showing workspace status should not nag about files not being in remote by default. Also it's annoying that there's no way to turn it off.

@dberenbaum
Copy link
Collaborator

Related to #9346.

Let's turn it off by default and replace --remote-refresh with --not-in-remote flag that both refreshes and shows the --not-in-remote status.

@dberenbaum dberenbaum added p1-important Important, aka current backlog of things to do A: cli Related to the CLI labels May 5, 2023
@efiop
Copy link
Contributor

efiop commented May 6, 2023

@dberenbaum But remote-refresh and not-in-remote do different things. You don't always want to refresh every time you want the remote status. We should have both if anything.

I'm a bit surprised that we are hiding remote status now, because it was meant to mimic git status and show all the useful info by default. I think this goes against the data status doc even? Or do you want to disable it temporarily?

@skshetry
Copy link
Member Author

skshetry commented May 6, 2023

git status does not show anything more than if you are behind or ahead of n number of commits, right?

@dberenbaum
Copy link
Collaborator

dberenbaum commented May 6, 2023

@efiop After having it around for a bit, it seems like including it by default is too noisy. What do you think of the approach in #9411 (it still keeps the option of whether to refresh)?

Having the git-like ability to check against the "index" is nice but pretty niche. In this case, we might not want to copy git because the git status behavior for remotes is not the most intuitive or helpful. In most scenarios I know, users want the local status (what needs to be committed), and when they care about the remote status, they mostly want to check the latest of what's on the remote (what needs to be pushed).

@efiop
Copy link
Contributor

efiop commented May 6, 2023

@dberenbaum I'm fine with making it opt-in if that's the consensus about it. Then we need to update the doc too (i mean that data status doc that you've created in notion).

Approach in #9411 makes sense to me 👍

@skshetry
Copy link
Member Author

skshetry commented May 6, 2023

I don't think the doc mentioned enabling this by default, just that there might be a section for the output, Not in remote. I see -c flag being used in the doc for remote statuses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: cli Related to the CLI p1-important Important, aka current backlog of things to do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants