Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp push: improve ui #9308

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Apr 5, 2023

Closes #9280.

@skshetry skshetry requested review from pmrowla and dberenbaum April 5, 2023 11:22
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Patch coverage: 47.61% and project coverage change: -0.04 ⚠️

Comparison is base (cf52efb) 92.94% compared to head (abf097c) 92.90%.

❗ Current head abf097c differs from pull request most recent head a1596d9. Consider uploading reports for the commit a1596d9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9308      +/-   ##
==========================================
- Coverage   92.94%   92.90%   -0.04%     
==========================================
  Files         459      459              
  Lines       37112    37151      +39     
  Branches     5342     5348       +6     
==========================================
+ Hits        34493    34515      +22     
- Misses       2089     2102      +13     
- Partials      530      534       +4     
Impacted Files Coverage Δ
tests/func/experiments/test_remote.py 100.00% <ø> (ø)
dvc/commands/experiments/push.py 65.00% <35.71%> (-21.49%) ⬇️
dvc/repo/experiments/push.py 77.41% <71.42%> (-3.27%) ⬇️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry skshetry force-pushed the exp-push-ui-improvement branch from ea5c084 to abf097c Compare April 5, 2023 13:26
Copy link
Collaborator

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple minor comments about messages, but nothing blocking.

skshetry added 2 commits April 6, 2023 09:48
- show url even when the refs are up-to-date.
- show url at the end
- add Git remote information in up-to-date UI message.
@skshetry skshetry merged commit 3c570a2 into iterative:main Apr 6, 2023
@skshetry skshetry deleted the exp-push-ui-improvement branch April 6, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exp push: clarify in UI what has been pushed to DVC and Git remotes
3 participants