Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp push: clarify in UI what has been pushed to DVC and Git remotes #9280

Closed
Tracked by #9074
dberenbaum opened this issue Mar 29, 2023 · 0 comments · Fixed by #9308
Closed
Tracked by #9074

exp push: clarify in UI what has been pushed to DVC and Git remotes #9280

dberenbaum opened this issue Mar 29, 2023 · 0 comments · Fixed by #9308
Assignees
Labels
A: experiments Related to dvc exp p1-important Important, aka current backlog of things to do

Comments

@dberenbaum
Copy link
Collaborator

dberenbaum commented Mar 29, 2023

dvc exp push is doing a lot, potentially pushing multiple experiments to Git, a DVC remote, and Studio. The output doesn't always make clear what happened, what was successful, and what failed.

Example 1: When the dvc push fails, the command errors out with no additional info even though the git push succeeded:

$ dvc exp push origin crank-prat
ERROR: unexpected error - [Errno 22] Bad Request: An error occurred (400) when calling the HeadObject operation: Bad Request

We should still show what was pushed to git even if we throw this error.

Example 2: When some experiments have already been pushed and some haven't, the message could better clarify that some of the experiments were already pushed:

$ dvc exp push --no-cache origin handy-puns lardy-vara
Pushed experiment 'lardy-vara' to Git remote 'origin'.
To push cached outputs for this experiment to DVC remote storage,re-run this command without '--no-cache'.

We should include that experiment 'handy-puns' was already pushed to that git remote.

Example 3: When the experiment was previously pushed with --no-cache, pushing again with the cache will take time to upload to the dvc remote but then report nothing was pushed:

$ dvc exp push origin lardy-vara
No experiments to push.

We should include the push output, like "9 files pushed to DVC remote 'storage'."

Example 4: Even when the experiment is successfully pushed, it would help to clarify that it was pushed not only to the Git remote but also to the DVC remote:

$ dvc exp push origin lushy-wool
Pushed experiment 'lushy-wool' to Git remote 'origin'.

This could use the same kind of output suggested for example 3.

@dberenbaum dberenbaum added the p1-important Important, aka current backlog of things to do label Mar 29, 2023
@dberenbaum dberenbaum added this to DVC Mar 29, 2023
@dberenbaum dberenbaum moved this from Backlog to Todo in DVC Mar 29, 2023
@github-project-automation github-project-automation bot moved this to Backlog in DVC Mar 29, 2023
@skshetry skshetry self-assigned this Apr 5, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in DVC Apr 6, 2023
@dberenbaum dberenbaum added the A: experiments Related to dvc exp label Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp p1-important Important, aka current backlog of things to do
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants