Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp diff: Remove --old option. #6888

Merged
merged 1 commit into from
Nov 12, 2021
Merged

exp diff: Remove --old option. #6888

merged 1 commit into from
Nov 12, 2021

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Oct 29, 2021

For consistency (#5515) with output format of other diff_table uses.

Docs P.R: iterative/dvc.org#2988


Before:

$ dvc exp diff exp-1dad0 exp-1df77

Path         Metric    Value    Change
scores.json  auc       0.51676  -0.060799

Path         Param                   Value    Change
params.yaml  featurize.max_features  500      -1500

After:

$ dvc exp diff exp-1dad0 exp-1df77

Path         Metric  exp-1dad0  exp-1df77  Change
scores.json  auc     0.577559   0.51676    -0.060799

Path         Param                   exp-1dad0  exp-1df77  Change
params.yaml  featurize.max_features  2000       500        -1500

After #6814 the header of `diff_table` is `a_rev/`b_rev` instead of `Old`/`New` so the name of the option was counterintuitive.

In addition, make `a_rev` show by default, for consistency with output format of other `diff_table` uses (`dvc metrics diff` / `dvc params diff`).
@daavoo daavoo requested a review from a team as a code owner October 29, 2021 18:29
@daavoo daavoo requested a review from isidentical October 29, 2021 18:29
@daavoo daavoo self-assigned this Nov 2, 2021
@daavoo daavoo added diff/show Related to the diff/show feature A: experiments Related to dvc exp feature is a feature labels Nov 2, 2021
@daavoo daavoo requested review from skshetry and removed request for isidentical November 4, 2021 12:39
@daavoo daavoo added enhancement Enhances DVC and removed feature is a feature labels Nov 5, 2021
@efiop efiop merged commit 28dd39a into master Nov 12, 2021
@efiop efiop deleted the unify-diff-behavior branch November 12, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp diff/show Related to the diff/show feature enhancement Enhances DVC
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants