Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated exp diff tables #2988

Merged
merged 3 commits into from
Nov 8, 2021
Merged

Updated exp diff tables #2988

merged 3 commits into from
Nov 8, 2021

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Oct 29, 2021

@daavoo daavoo added ⌛ status: wait-core-merge Waiting for related product PR merge/release C: ref Content of /doc/*-reference labels Oct 29, 2021
@shcheklein shcheklein temporarily deployed to dvc-org-exp-diff-old-re-oxxe2k October 29, 2021 18:44 Inactive
@daavoo daavoo force-pushed the exp-diff-old-removed branch from 1e13c5e to 75498fa Compare November 4, 2021 12:42
@shcheklein shcheklein temporarily deployed to dvc-org-exp-diff-old-re-oxxe2k November 4, 2021 12:43 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-exp-diff-old-re-oxxe2k November 4, 2021 13:31 Inactive
@daavoo daavoo requested review from iesahin and dberenbaum November 4, 2021 13:35
Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the synopsis section of the cmd ref, --old is still shown as an option.

Also, where are the related core/docs PRs for metrics diff --old?

@daavoo
Copy link
Contributor Author

daavoo commented Nov 4, 2021

Also, where are the related core/docs PRs for metrics diff --old?

There is not such an option for dvc metrics diff (And, afaik, it has never existed). It looks like the docs are not in sync with the command

@shcheklein shcheklein temporarily deployed to dvc-org-exp-diff-old-re-oxxe2k November 4, 2021 17:21 Inactive
@iesahin iesahin merged commit 3f4a2a4 into master Nov 8, 2021
@iesahin iesahin deleted the exp-diff-old-removed branch November 8, 2021 16:32
@jorgeorpinel
Copy link
Contributor

There is not such an option

It must have existed when @iesahin wrote this. Anyway, thanks for the update!

@iesahin
Copy link
Contributor

iesahin commented Nov 12, 2021

FYI --old joined to dvc metrics diff options in https://github.com/iterative/dvc.org/pull/1360/files

@daavoo @jorgeorpinel

@jorgeorpinel
Copy link
Contributor

Now, that's --old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: ref Content of /doc/*-reference ⌛ status: wait-core-merge Waiting for related product PR merge/release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants