Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: support directory imports with azure #6245

Merged
merged 5 commits into from
Jul 13, 2021

Conversation

isidentical
Copy link
Contributor

Resolves #4693

@isidentical isidentical requested a review from efiop June 29, 2021 07:08
@isidentical isidentical requested a review from a team as a code owner June 29, 2021 07:08
@isidentical
Copy link
Contributor Author

It seems like there is an Azurite issue: Azure/Azurite#839. Awaiting resolution on that end

@isidentical isidentical marked this pull request as draft June 29, 2021 08:29
@isidentical
Copy link
Contributor Author

Azurite regression seems to happen only on 3.13, so we should be safe with 3.12 for the time being. But there is another issue: apparently there were a regression on adlfs, and there is a code path which might lead to 3.6 imcompatible API calls (asyncio.get_running_loop()). Reported fsspec/adlfs#251

@isidentical isidentical marked this pull request as ready for review July 12, 2021 10:57
@isidentical
Copy link
Contributor Author

CC: @efiop

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isidentical Sorry, totally blinded this one.

@efiop efiop merged commit 58f0911 into iterative:master Jul 13, 2021
@efiop efiop added the enhancement Enhances DVC label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances DVC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dvc import-url fails for folders in azure remote.
2 participants