Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.6 regression: get_running_loop() #251

Closed
isidentical opened this issue Jun 29, 2021 · 3 comments · Fixed by #252
Closed

3.6 regression: get_running_loop() #251

isidentical opened this issue Jun 29, 2021 · 3 comments · Fixed by #252

Comments

@isidentical
Copy link
Member

The asyncio.gat_running_loop() is introduced in 3.7, but adlfs uses it which regressed the 3.6 support. The latest version of fsspec comes with fsspec.asyn.get_running_loop() which could be used instead of asyncio.get_running_loop() since it support 3.6 too!
This was referenced Jun 29, 2021
Merged
Merged
@isidentical
Copy link
Member Author

A gentle ping about this (it is blocking us from migrating to the newer versions of adlfs)

@hayesgb
Copy link
Collaborator

hayesgb commented Jul 7, 2021

It's failing the DEV check...

@isidentical
Copy link
Member Author

It's failing the DEV check...

See fsspec/filesystem_spec#688 for the reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adlfs: use fsspec.asyn.get_running_loop() isidentical/adlfs
2 participants
@hayesgb @isidentical