New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncFileSystem regression: _makedirs #688

Closed

isidentical opened this issue Jul 1, 2021 · 0 comments · Fixed by #689

Member

isidentical commented Jul 1, 2021

#686 introduced a requirement over _makedirs() of the downstream filesystems, which is something optional according to this list;
https://github.com/intake/filesystem_spec/blob/ce0b70320d5d8704a97aafa45b17b8e60bd8ecd5/fsspec/asyn.py#L210-L230

I think there should be empty methods _mkdir/_makedirs that does nothing:
https://github.com/intake/filesystem_spec/blob/ce0b70320d5d8704a97aafa45b17b8e60bd8ecd5/fsspec/spec.py#L264-L296

The text was updated successfully, but these errors were encountered:

isidentical mentioned this issue

async: add _mkdir/_makedirs to the async methods list #689

Merged

martindurant closed this as completed in #689

isidentical mentioned this issue

3.6 regression: get_running_loop() fsspec/adlfs#251

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment