Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_update_import: roll back skip #4781

Merged
merged 1 commit into from
Oct 26, 2020
Merged

test_update_import: roll back skip #4781

merged 1 commit into from
Oct 26, 2020

Conversation

pared
Copy link
Contributor

@pared pared commented Oct 23, 2020 •
edited
Loading

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Related to #4418.

@pared pared changed the title test_update_import: roll back skip [WIP] test_update_import: roll back skip Oct 23, 2020
@pared
Copy link
Contributor Author

pared commented Oct 23, 2020 •
edited
Loading

Well, that one is easy. Seems like the problem disappeared.
I though some change has fixed the issue, but to my surprise, my own run with skip removed on top of original commit introducing github actions is also passing. It seems like something must have changed in a way how the runner (or one of the actions) is handling our project and now it passes without the original problem.

EDIT:
the run

@pared pared requested review from efiop and pmrowla October 23, 2020 14:55
@tomasfarias tomasfarias mentioned this pull request Oct 24, 2020
Closed
@pared pared changed the title [WIP] test_update_import: roll back skip test_update_import: roll back skip Oct 26, 2020
@pared pared force-pushed the 4418_test_update_import branch from 757c9d9 to 2c9115c Compare October 26, 2020 06:18
@pared pared added skip-changelog Skips changelog testing Related to the tests and the testing infrastructure labels Oct 26, 2020
@pared pared force-pushed the 4418_test_update_import branch from c8c3332 to 2c9115c Compare October 26, 2020 11:22
@efiop efiop merged commit 4d75e75 into iterative:master Oct 26, 2020
@pared pared deleted the 4418_test_update_import branch January 4, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrowla pmrowla pmrowla approved these changes

@efiop efiop Awaiting requested review from efiop

Assignees
No one assigned
Labels
skip-changelog Skips changelog testing Related to the tests and the testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pared @pmrowla @efiop