Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting failures caused by using dict with keyword arguments #4783

Closed
tomasfarias opened this issue Oct 24, 2020 · 0 comments · Fixed by #4784
Closed

Linting failures caused by using dict with keyword arguments #4783

tomasfarias opened this issue Oct 24, 2020 · 0 comments · Fixed by #4784

Comments

@tomasfarias
Copy link
Contributor

tomasfarias commented Oct 24, 2020

Bug Report

Please provide information about your setup

Output of dvc version:

dvc version
DVC version: 1.8.4+e1e2a4
---------------------------------
Platform: Python 3.8.6 on Linux-4.19.128-microsoft-standard-x86_64-with-glibc2.32
Supports: All remotes
Cache types: hardlink, symlink
Cache directory: ext4 on /dev/sdb
Workspace directory: ext4 on /dev/sdb
Repo: dvc, git

Note: This should also happen in 1.9.0 since it doesn't have to do with dvc itself but with flake-comprehensions, I just happen to be working in 1.8.4 at the moment.

Additional Information (if any):

flake-comprehensions reverted a change and is now flagging all dict calls with keyword arguments (e.g. dict(a=value, another=value)). See commit here: adamchainz/flake8-comprehensions@b1cfd5a. This is causing linting failures in all recent PRs and should keep happening since the offending lines are in master branch. See a few examples:

Best solution, afaik, would be to execute the suggested changes and replace dict calls with literals.

This was referenced Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant