tests: abstract remote setup to fixture #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
reviewed
May 6, 2020
pared
changed the title
pared
force-pushed
the
fix_erepo_remote
branch
2 times, most recently
from
ebe2e8f to
03b5e99
Compare
pared
changed the title
pmrowla
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fixes #2888, related to #3416
The problem:
In #3416 I could reproduce user problems in script, but it seemed that I am unable to write a test for it.
The problem turned out to be related to the fact that
erepo_dirhas been setting its default remote to be its cache. Due to that, I have been indirectly using cache "read only mode" optimization, while using remote. Because it is the second time i stumble upon this issue (#2888) I decided to fix it.This issue introduces "setup_remote" fixture, which is intended to be default way to set up the remote for particular
Repoinstance.