Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: erepo upstream should not be its cache #2888

Closed
pared opened this issue Dec 4, 2019 · 1 comment · Fixed by #3748
Closed

tests: erepo upstream should not be its cache #2888

pared opened this issue Dec 4, 2019 · 1 comment · Fixed by #3748
Labels
p2-medium Medium priority, should be done, but less important refactoring Factoring and re-factoring testing Related to the tests and the testing infrastructure

Comments

@pared
Copy link
Contributor

pared commented Dec 4, 2019

Setting default remote as repository cache inside erepo is kinda hacky. This is not a real use case, and some test relay on the erepo property (that is automatically adding cached files to remote because cache and remote are the same thing). erepo remote should not be its cache.

This issue will probably be obsolete after #2599. In that case, the code responsible for setting remote in erepo should be completely removed.

Related #2852
@triage-new-issues triage-new-issues bot added the triage Needs to be triaged label Dec 4, 2019
@pared pared mentioned this issue Dec 4, 2019
Merged
3 tasks
@efiop efiop added refactoring Factoring and re-factoring testing Related to the tests and the testing infrastructure labels Dec 4, 2019
@triage-new-issues triage-new-issues bot removed triage Needs to be triaged labels Dec 4, 2019
@efiop efiop added p2-medium Medium priority, should be done, but less important triage Needs to be triaged labels Dec 4, 2019
@triage-new-issues triage-new-issues bot removed the triage Needs to be triaged label Dec 4, 2019
@weekly-digest weekly-digest bot mentioned this issue Dec 8, 2019
Closed
@pared
Copy link
Contributor Author

pared commented May 6, 2020

Related #3416

This was referenced May 6, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p2-medium Medium priority, should be done, but less important refactoring Factoring and re-factoring testing Related to the tests and the testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: abstract remote setup to fixture pared/dvc
2 participants
@efiop @pared