-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdrive: fix multi-remote workflow, cont. cleanup #3686
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3686 +/- ##
==========================================
- Coverage 90.77% 90.65% -0.12%
==========================================
Files 158 158
Lines 10001 10018 +17
==========================================
+ Hits 9078 9082 +4
- Misses 923 936 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions and suggestions on cmd output.
Co-Authored-By: Jorge Orpinel <[email protected]>
Co-Authored-By: Jorge Orpinel <[email protected]>
Co-Authored-By: Jorge Orpinel <[email protected]>
Co-Authored-By: Jorge Orpinel <[email protected]>
c9480fa
to
238d6ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more details for your consideration ☝️
238d6ed
to
5adb714
Compare
Address more checkboxes from the #2865.
Specifically:
gdrive_user_credentials_file
is handled - it should be resolved against config location if it is relative.Docs PR: iterative/dvc.org#1192
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏