gdrive: add gdrive_user_credentials_file description #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
jorgeorpinel
suggested changes
Apr 28, 2020
Comment on lines
+202
to
+203
| `.dvc/tmp/gdrive-user-credentials.json` and they will be used automatically next | ||
| time you run DVC. |
There was a problem hiding this comment.
Suggested change
| `.dvc/tmp/gdrive-user-credentials.json` and they will be used automatically next | |
| time you run DVC. | |
| `.dvc/tmp/gdrive-user-credentials.json` by default, and they will be loaded | |
| automatically next time you use the same GDrive remote. |
There was a problem hiding this comment.
this is not exactly true, they can be used for multiple remotes if you don't specify an option gdrive_user_credentials_file
There was a problem hiding this comment.
Got it. But "run DVC" doesn't sound exact either. How about
Suggested change
| `.dvc/tmp/gdrive-user-credentials.json` and they will be used automatically next | |
| time you run DVC. | |
| `.dvc/tmp/gdrive-user-credentials.json` by default, and they will be loaded | |
| automatically next time you use this or other GDrive remotes. |
Maybe even continue this paragraph with the explanation about how to overwrite it, instead of a separate paragraph that repeats the file name.
Co-Authored-By: Jorge Orpinel <[email protected]>
Comment on lines
+209
to
+210
| If you use multiple GDrive remotes, by default they will be sharing the same | ||
| `.dvc/tmp/gdrive-user-credentials.json` credentials file. It can be overridden |
There was a problem hiding this comment.
Maybe we don't need to repeat the file name since it's mentioned in in the previous paragraph (before the warning).
jorgeorpinel
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding core DVC PR iterative/dvc#3686
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please chose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏