Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion: bash: properly recurse targets #3374

Merged
merged 3 commits into from
Feb 21, 2020

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Feb 20, 2020

Notes

  • -o nospace is required (as documented in the code) to avoid an unreasonable rewrite of everything.
  • the snap package automatically benefits from this PR :)
  • I'm tempted to write a test for future use, and perhaps even think of a way to automate based on argparse but that way likely lieth a massive independent project moste arcane.
    • have manually tested all current permutations though

I haven't seen any code examples take this approach and don't know why. It looks elegant, maintainable, and efficient to me.

@casperdcl casperdcl added bug Did we break something? enhancement Enhances DVC refactoring Factoring and re-factoring ui user interface / interaction research completion bash and zsh completion scripts labels Feb 20, 2020
@casperdcl casperdcl requested a review from efiop February 20, 2020 23:25
@casperdcl casperdcl self-assigned this Feb 20, 2020
@casperdcl
Copy link
Contributor Author

I haven't seen any code examples take this approach and don't know why. It looks elegant, maintainable, and efficient to me.

Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@efiop efiop merged commit 411057d into iterative:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? completion bash and zsh completion scripts enhancement Enhances DVC refactoring Factoring and re-factoring research ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

completion: bash: handle subdirs Autocomplete for file names doesn't work (partially) [bash]
2 participants