completion: bash: properly recurse targets #3374
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
-o nospace
is required (as documented in the code) to avoid an unreasonable rewrite of everything.snap
package automatically benefits from this PR :)argparse
but that way likely lieth a massive independent project moste arcane.I haven't seen any code examples take this approach and don't know why. It looks elegant, maintainable, and efficient to me.