Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash completion #3360

Merged
merged 5 commits into from
Feb 19, 2020
Merged

Fix bash completion #3360

merged 5 commits into from
Feb 19, 2020

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Feb 18, 2020

Caveats:

  • still won't allow completion of subdir paths. That would require a major enough overhaul that it's probably for another PR.

@casperdcl casperdcl self-assigned this Feb 18, 2020
@casperdcl casperdcl added bug Did we break something? ui user interface / interaction completion bash and zsh completion scripts enhancement Enhances DVC labels Feb 18, 2020
@casperdcl casperdcl marked this pull request as ready for review February 18, 2020 23:38
@casperdcl
Copy link
Contributor Author

btw just a quick check - is there any instance where a command should autocomplete with BOTH DVC-files as well as non-DVC-files?

@efiop
Copy link
Contributor

efiop commented Feb 19, 2020

btw just a quick check - is there any instance where a command should autocomplete with BOTH DVC-files as well as non-DVC-files?

@casperdcl pull/push/fetch/status/checkout 🙂 They all support specifying particular output instead of dvc-file.

@casperdcl
Copy link
Contributor Author

Great this is mergeable then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Did we break something? completion bash and zsh completion scripts enhancement Enhances DVC ui user interface / interaction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete for file names doesn't work (partially) [bash]
2 participants