import url: test: migrate to dir helpers #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Jan 6, 2020
tests/func/test_import_url.py
Outdated
| src = repo_dir.DATA | ||
| def test_import_url_to_dir(dname, tmp_dir, dvc): | ||
| tmp_dir.gen({"data_dir": {"imported_file": "file content"}}) | ||
| src = os.path.join("data_dir", "imported_file") |
There was a problem hiding this comment.
But src is not imported, dst is imported_file. This is confusing. Also, instead of filecmp please use read_text() == "something".
efiop
suggested changes
Jan 7, 2020
tests/func/test_import_url.py
Outdated
|
|
||
| dst = os.path.join(dname, os.path.basename(src)) | ||
| dst = os.path.join(dname, "file") |
There was a problem hiding this comment.
Minor comment:
Suggested change
| dst = os.path.join(dname, "file") | |
| dst = tmp_dir / dname / "file" |
and then you could
stage.outs[0] == dst
and so on.
efiop
reviewed
Jan 8, 2020
efiop
reviewed
Jan 8, 2020
Co-Authored-By: Ruslan Kuprieiev <[email protected]>
Co-Authored-By: Ruslan Kuprieiev <[email protected]>
efiop
reviewed
Jan 8, 2020
Co-Authored-By: Ruslan Kuprieiev <[email protected]>
|
For the record: tests failing due to unrelated changes. |
efiop
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏