Skip to content

Commit

Permalink
import url: test: migrate to dir helpers
Browse files Browse the repository at this point in the history
  • Loading branch information
pared committed Jan 8, 2020
1 parent 2966924 commit 62d6f4d
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions tests/func/test_import_url.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import filecmp
import os
from uuid import uuid4

import pytest
from mock import patch

import dvc
from dvc.compat import fspath
from dvc.main import main
from dvc.utils import makedirs
from tests.basic_env import TestDvc
Expand Down Expand Up @@ -90,15 +90,16 @@ def test(self):


@pytest.mark.parametrize("dname", [".", "dir", "dir/subdir"])
def test_import_url_to_dir(dname, repo_dir, dvc_repo):
src = repo_dir.DATA
def test_import_url_to_dir(dname, tmp_dir, dvc):
tmp_dir.gen({"data_dir": {"file": "file content"}})
src = os.path.join("data_dir", "file")

makedirs(dname, exist_ok=True)

stage = dvc_repo.imp_url(src, dname)
stage = dvc.imp_url(src, dname)

dst = os.path.join(dname, os.path.basename(src))
dst = tmp_dir / dname / "file"

assert stage.outs[0].fspath == os.path.abspath(dst)
assert stage.outs[0].fspath == fspath(dst)
assert os.path.isdir(dname)
assert filecmp.cmp(repo_dir.DATA, dst, shallow=False)
assert (tmp_dir / dname / "file").read_text() == "file content"

0 comments on commit 62d6f4d

Please sign in to comment.