Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp: remove <queued_experiment> #6157

Closed
casperdcl opened this issue Jun 11, 2021 · 0 comments · Fixed by #6393
Closed

exp: remove <queued_experiment> #6157

casperdcl opened this issue Jun 11, 2021 · 0 comments · Fixed by #6393
Assignees
@karajan1001
Labels
A: experiments Related to dvc exp feature request Requesting a new feature p1-important Important, aka current backlog of things to do

Comments

@casperdcl
Copy link
Contributor

Currently exp remove doesn't work for a single queued experiment. This is a problem if 1001 experiments are queued but the last one was an accident. Starting from scratch (dvc exp remove --queue) is a poor solution.
@casperdcl casperdcl added feature request Requesting a new feature A: experiments Related to dvc exp labels Jun 11, 2021
@dberenbaum dberenbaum added the p2-medium Medium priority, should be done, but less important label Jun 11, 2021
@dberenbaum dberenbaum mentioned this issue Jun 16, 2021
Closed
@karajan1001 karajan1001 self-assigned this Jul 27, 2021
karajan1001 added a commit to karajan1001/dvc that referenced this issue Aug 9, 2021
@karajan1001
Remove a special queued experiments
4dca420 
fix iterative#6157
1. dvc exp remove not accept queued experiments name
2. add some tests for this feature
@karajan1001 karajan1001 mentioned this issue Aug 9, 2021
Merged
2 tasks
@dberenbaum dberenbaum added p1-important Important, aka current backlog of things to do and removed p2-medium Medium priority, should be done, but less important labels Aug 12, 2021
karajan1001 added a commit that referenced this issue Aug 13, 2021
@karajan1001
Remove a special queued experiments (#6393)
de97a49 
* Remove a special queued experiments

fix #6157
1. dvc exp remove not accept queued experiments name
2. add some tests for this feature

* Extract tests and add revision support

1. Extract remove experiments to a new file.
2. revision can be used to remove special queued experiment

* Accept shortened revisions

* Split removing committed and queued exp functions

* Api name change

* Return to the old API name

* shorten some functions

* Error message change

* Better test cases, more corner case

* Still raise exception in a mixed case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karajan1001 karajan1001

Labels
A: experiments Related to dvc exp feature request Requesting a new feature p1-important Important, aka current backlog of things to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove a special queued experiments karajan1001/dvc
3 participants
@dberenbaum @karajan1001 @casperdcl