Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp show: show names for the queued experiments #6050

Closed
aguschin opened this issue May 24, 2021 · 5 comments · Fixed by #6382
Closed

exp show: show names for the queued experiments #6050

aguschin opened this issue May 24, 2021 · 5 comments · Fixed by #6382
Assignees
Labels
A: experiments Related to dvc exp discussion requires active participation to reach a conclusion p1-important Important, aka current backlog of things to do ui user interface / interaction

Comments

@aguschin
Copy link
Contributor

aguschin commented May 24, 2021

It would be great to see the name of a queued experiment. Right now if we run, for example

dvc exp run --queue -S model.cnn.dropout=0.25 -n named-one

the table below won't show it's name right away:
image
only after we run it with dvc exp run --run-all:
image

We could live fine without names, but if for example we want to review multiple queued experiments with dvc exp show and look for what we forgot to add to the queue, it would be helpful to see them.

Another use case which is not supported now, AFAK, is to remove queued experiments. If I added few experiments, I may want to remove one of them before running them all. Right now I need to reset all queued experiments with dvc exp remove --queue and add required ones again. This removal would be convenient to do if we could reference the queued experiments by their names. If it seems like a valid use case and dvc has no such feature, I can create a feature request.

@aguschin aguschin added the discussion requires active participation to reach a conclusion label May 24, 2021
@aguschin aguschin changed the title Show names for the queued experiments exp show: show names for the queued experiments May 24, 2021
@dberenbaum
Copy link
Collaborator

#5965 also has some loosely related discussion about whether the final exp name should be shown in the queue from the beginning. @pmrowla what do you think? Not sure how important this is or how difficult to implement, but it does seems like it's a strict improvement on current behavior.

@pmrowla
Copy link
Contributor

pmrowla commented May 25, 2021

If the user is specifying a name with -n/--name we can display it for queued experiments.

When it comes to the current autogenerated names we cannot generate them for queued experiments, as they are derived from the resulting pipeline after reproduction. So displaying autogenerated names for queued experiments will require changing how we autogenerate names.

Regarding removing queue experiments, that will happen eventually along with proper queue management in general (#5615)


Regarding priority, I don't think it's worth it to put much time into how exp show handles queued experiments right now, since eventually exp queue will likely have it's own UI entirely.

@pmrowla pmrowla added p3-nice-to-have It should be done this or next sprint ui user interface / interaction labels May 25, 2021
@jorgeorpinel
Copy link
Contributor

If the user is specifying a name with -n/--name we can display it for queued experiments.

👍

@dberenbaum dberenbaum added the A: experiments Related to dvc exp label Jun 16, 2021
@dberenbaum
Copy link
Collaborator

Another use case which is not supported now, AFAK, is to remove queued experiments. If I added few experiments, I may want to remove one of them before running them all. Right now I need to reset all queued experiments with dvc exp remove --queue and add required ones again. This removal would be convenient to do if we could reference the queued experiments by their names. If it seems like a valid use case and dvc has no such feature, I can create a feature request.

@aguschin This part got lost in the discussion, but see #6157.

@pmrowla I think it would be helpful to add this to the loose ends to clean up for experiments. It's not clear if or when we will have a separate exp queue command, or whether that will address this problem since the queue might still also show in exp show. How much work do you think it is to show named experiments in the queue?

@pmrowla
Copy link
Contributor

pmrowla commented Jun 17, 2021

@pmrowla How much work do you think it is to show named experiments in the queue?

@dberenbaum this is pretty much just a one liner UI change. We already have names for queued experiments internally, we just don't show them in the UI right now.

@dberenbaum dberenbaum added p1-important Important, aka current backlog of things to do and removed p3-nice-to-have It should be done this or next sprint labels Jul 19, 2021
@karajan1001 karajan1001 self-assigned this Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Related to dvc exp discussion requires active participation to reach a conclusion p1-important Important, aka current backlog of things to do ui user interface / interaction
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants