Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: note that queued exps don't have hash or name yet (in exp show) #2499

Closed
aguschin opened this issue May 24, 2021 · 9 comments
Closed

ref: note that queued exps don't have hash or name yet (in exp show) #2499

aguschin opened this issue May 24, 2021 · 9 comments
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@aguschin
Copy link
Contributor

Wanted to share something I struggled a bit while trying out Experiments. For a new user it could be not clear that dvc exp run --queue produces an experiment with a star behind an experiment name, for example *123456, that becomes something like 1618ad3 [exp-c043c] after dvc exp run --run-all. It would be great to add dvc exp show output for clarity and add a few words on why the hashes change (from *123456 to 1618ad3 [exp-c043c]) just after the code snippet with dvc exp run --queue ... here https://dvc.org/doc/start/experiments
image

@aguschin aguschin changed the title Show dvc exp show output with queued experiments in "Get started > Experiments" start: show dvc exp show output with queued experiments in "Get started > Experiments" May 24, 2021
@aguschin aguschin changed the title start: show dvc exp show output with queued experiments in "Get started > Experiments" start: show dvc exp show output with queued experiments May 24, 2021
@shcheklein
Copy link
Member

cc @iesahin

@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions labels May 24, 2021
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented May 25, 2021

For a new user it could be not clear that dvc exp run --queue produces an experiment with a star behind an experiment name, for example *123456

We don't introduce exp show until the next section though. Can you elaborate on why you struggled with that @aguschin ? Maybe you were jumping ahead 🤓

I'm not sure that we want to explain that specific detail about exp show tables here TBH. https://dvc.org/doc/command-reference/exp/show could mention this though, and/or show an example with queued exps.

p.s. I'd shorten that list of queued runs to max 3 though... cc @iesahin 😬 (per #2491)

@jorgeorpinel jorgeorpinel changed the title start: show dvc exp show output with queued experiments start: dvc exp show output with queued experiments May 25, 2021
@dberenbaum
Copy link
Contributor

dberenbaum commented May 25, 2021

🤔 Good point, @jorgeorpinel.

@aguschin Keep in mind that a major focus of this section is to keep it as short and simple as possible, so is this important enough for a first impression of experiments?

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented May 25, 2021

something I struggled a bit while trying out Experiments

BTW this feedback is still very valuable. Please do elaborate so we can think of an alternative way to improve on it.

@aguschin
Copy link
Contributor Author

aguschin commented May 26, 2021

@dberenbaum, yes, for the first impression it is enough, I think.

@jorgeorpinel, I was confused at the point I started to use dvc exp locally with the example repo. I expected that the queued experiment that the exp show mentions as lets say *123456 will still be mentioned as something with 123456 after exp run --all-runs in exp show, not something completely different (1618ad3 [exp-c043c]). For example, 123456 [exp-c043c] or 1618ad3 [exp-123456], or something like that.

First I though it was a bug and my experiment was lost somewhere, but after a few tries I got it that this "reference" to experiment in the table changes. Ideally it would be great to change the mechanism this references are assigned to keep it the same, but it's not going to happen now iterative/dvc#6050. I think it's still good to elaborate it somewhere so the user could have an understanding what happens here right after reading the docs :)

@iesahin
Copy link
Contributor

iesahin commented May 26, 2021

I used -n parameter in the examples more to avoid this confusion in #2497

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented May 27, 2021

that the queued experiment that the exp show mentions as lets say *123456 will still be mentioned as something with 123456 after exp run --all-runs in exp show
First I though it was a bug and my experiment was lost somewhere...

I see! That's because they don't have actual hashes or ref. names before they run (they're not commits yet).

but it's not going to happen now iterative/dvc#6050. I think it's still good to elaborate it somewhere

Yes I agree we should mention this somewhere. Just probably not here: shouldn't be confusing as exp show hasn't been introduced yet. Let me think 🤔

I used -n parameter in the examples more to avoid this confusion

@iesahin I tried it locally and the name is still not shown by exp show so that wouldn't help 🙁 (for now, see iterative/dvc#6050 (comment))

$ dvc exp run --queue -n myname
$ dvc exp show --no-pager
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Experiment   ┃ Created      ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ workspace    │ -            │
│ master       │ May 22, 2021 │
│ └── *5072852 │ 01:22 PM     │
└──────────────┴──────────────┘

@jorgeorpinel jorgeorpinel changed the title start: dvc exp show output with queued experiments exp show: explain queued experiment references (there's no commit hash or commit name yet) May 27, 2021
@jorgeorpinel
Copy link
Contributor

I agree we should mention this somewhere

There's a note in https://dvc.org/doc/command-reference/exp/run#queueing-and-parallel-execution that could be updated: "dvc exp show will mark queued experiments with an asterisk *."

And I'd also introduce a note or section about queued/tmp exps in https://dvc.org/doc/command-reference/exp/show

@aguschin please lmk if you're still interested in submitting a draft PR on this (we're happy to take it over after a round of review).

@jorgeorpinel jorgeorpinel changed the title exp show: explain queued experiment references (there's no commit hash or commit name yet) ref: note that queued exps don't have hash or name yet (in exp show) May 31, 2021
@iesahin iesahin removed the dvc label Oct 14, 2021
@iesahin iesahin added the C: ref Content of /doc/*-reference label Oct 21, 2021
@dberenbaum
Copy link
Contributor

Closing as outdated (queued experiments now get regular exp names)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

No branches or pull requests

5 participants