-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: note that queued exps don't have hash or name yet (in exp show
)
#2499
Comments
dvc exp show
output with queued experiments in "Get started > Experiments"dvc exp show
output with queued experiments in "Get started > Experiments"
dvc exp show
output with queued experiments in "Get started > Experiments"dvc exp show
output with queued experiments
cc @iesahin |
We don't introduce I'm not sure that we want to explain that specific detail about p.s. I'd shorten that list of queued runs to max 3 though... cc @iesahin 😬 (per #2491) |
dvc exp show
output with queued experimentsdvc exp show
output with queued experiments
🤔 Good point, @jorgeorpinel. @aguschin Keep in mind that a major focus of this section is to keep it as short and simple as possible, so is this important enough for a first impression of experiments? |
BTW this feedback is still very valuable. Please do elaborate so we can think of an alternative way to improve on it. |
@dberenbaum, yes, for the first impression it is enough, I think. @jorgeorpinel, I was confused at the point I started to use First I though it was a bug and my experiment was lost somewhere, but after a few tries I got it that this "reference" to experiment in the table changes. Ideally it would be great to change the mechanism this references are assigned to keep it the same, but it's not going to happen now iterative/dvc#6050. I think it's still good to elaborate it somewhere so the user could have an understanding what happens here right after reading the docs :) |
I used |
I see! That's because they don't have actual hashes or ref. names before they run (they're not commits yet).
Yes I agree we should mention this somewhere. Just probably not here: shouldn't be confusing as
@iesahin I tried it locally and the name is still not shown by $ dvc exp run --queue -n myname
$ dvc exp show --no-pager
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┓
┃ Experiment ┃ Created ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━┩
│ workspace │ - │
│ master │ May 22, 2021 │
│ └── *5072852 │ 01:22 PM │
└──────────────┴──────────────┘ |
dvc exp show
output with queued experimentsexp show
: explain queued experiment references (there's no commit hash or commit name yet)
There's a note in https://dvc.org/doc/command-reference/exp/run#queueing-and-parallel-execution that could be updated: "dvc exp show will mark queued experiments with an asterisk *." And I'd also introduce a note or section about queued/tmp exps in https://dvc.org/doc/command-reference/exp/show @aguschin please lmk if you're still interested in submitting a draft PR on this (we're happy to take it over after a round of review). |
exp show
: explain queued experiment references (there's no commit hash or commit name yet)exp show
)
Closing as outdated (queued experiments now get regular exp names) |
Wanted to share something I struggled a bit while trying out Experiments. For a new user it could be not clear that
dvc exp run --queue
produces an experiment with a star behind an experiment name, for example*123456
, that becomes something like1618ad3 [exp-c043c]
afterdvc exp run --run-all
. It would be great to adddvc exp show
output for clarity and add a few words on why the hashes change (from*123456
to1618ad3 [exp-c043c]
) just after the code snippet withdvc exp run --queue ...
here https://dvc.org/doc/start/experimentsThe text was updated successfully, but these errors were encountered: