[WIP] engine: move static/ contents into public/ and update links #879
Conversation
jorgeorpinel
changed the title
src/Tooltip/index.js
Outdated
| import glossary from '../../static/docs/glossary' | ||
| import glossary from '../../public/static/docs/glossary' |
There was a problem hiding this comment.
@iAdramelk @shcheklein Isn't it a little funny to import a static asset from src code? I know we talked about this change but I didn't realize this would be the result 😋
There was a problem hiding this comment.
In perfect world it, together with the md files, should be placed in the content folder in root directory and moved automatically to public folder at build time, but in next.js we would need to do it by hand and it's too bothersome.
There was a problem hiding this comment.
OK makes sense. I'll leave this review open for future ref.
to complete previous commit's intended change
jorgeorpinel
temporarily deployed
to
dvc-landing-jorgeorpine-bvadoh
jorgeorpinel
changed the title
update all links from contents WITHOUT proper formatting (yet). See https://nextjs.org/docs#static-file-serving-eg-images
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Yep same. /doc shows the 404 page (with a 200 status code BTW). Other /doc/{valid} routes also show 404s (but with actual 404 code). The strange thing is that it works on https://dvc-landing-jorgeorpine-bvadoh.herokuapp.com/doc 😋 which is why I think it has to do both with my move from static to public, and with your changes in #872 – specifically https://github.com/iterative/dvc.org/pull/872/files#diff-78c12f5adc1848d13b1c6f07055d996eR110-R113 maybe. I'll look into it... |
to close #804
jorgeorpinel
temporarily deployed
to
dvc-landing-jorgeorpine-bvadoh
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jorgeorpinel
changed the title
This comment has been minimized.
This comment has been minimized.
jorgeorpinel
temporarily deployed
to
dvc-landing-jorgeorpine-bvadoh
Failed miserably. We installed Restyled on this repo but the check is just not coming up. 🤷♂ Removed the config file for now. |
|
Hahaha. Now it works!
... |
jorgeorpinel
temporarily deployed
to
dvc-landing-jorgeorpine-bvadoh
|
I added the .restyled.yaml config file again but Restyled thinks there's "No differences". Weird. I'll try to close and reopen the PR... |
Per node 9.0.6+ update
See https://github.com/zeit/next.js/blob/master/errors/static-dir-deprecated.md
And https://nextjs.org/docs#static-file-serving-eg-images
+ close #804 (adopt restyled.io) using this PR to test it.