Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #697: Make unexisting docs pages return 404 status #872

Merged
merged 3 commits into from
Dec 19, 2019
Merged

Fix #697: Make unexisting docs pages return 404 status #872

merged 3 commits into from
Dec 19, 2019

Conversation

iAdramelk
Copy link
Contributor

@iAdramelk iAdramelk commented Dec 17, 2019 •
edited
Loading

Fix #697. Add check for /doc pages in server.js, if page does not exists, it return correct status.

@shcheklein shcheklein temporarily deployed to dvc-landing-gf-fix--697-6aoek3 December 17, 2019 12:45 Inactive
shcheklein
shcheklein requested changes Dec 17, 2019
View reviewed changes
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utils/sidebar.json is a strange location for the file? can we move it anywhere at all?

jorgeorpinel
jorgeorpinel reviewed Dec 17, 2019
View reviewed changes
utils/helper.js Outdated Show resolved Hide resolved
jorgeorpinel
jorgeorpinel reviewed Dec 17, 2019
View reviewed changes
utils/helper.js Outdated Show resolved Hide resolved
jorgeorpinel
jorgeorpinel reviewed Dec 17, 2019
View reviewed changes
utils/helper.js Outdated Show resolved Hide resolved
@jorgeorpinel
Copy link
Contributor

I tested the deployment and it works, thanks @iAdramelk! Seems like we just have minor concerns here 🙂 ^

@iAdramelk

This comment has been minimized.

Sign in to view
@shcheklein

This comment has been minimized.

Sign in to view
@shcheklein shcheklein temporarily deployed to dvc-landing-gf-fix--697-6aoek3 December 18, 2019 13:04 Inactive
@iAdramelk
Copy link
Contributor Author

Updated names and locations:

utils/helper.js -> src/utils/sidebar.js
utils/sidebar.json -> static/docs/sidebar.json

Also updated path to sidebar.json in docs.

jorgeorpinel
jorgeorpinel suggested changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just pending resolving #872 (review)

@jorgeorpinel jorgeorpinel merged commit 9ee6eac into master Dec 19, 2019
@weekly-digest weekly-digest bot mentioned this pull request Dec 22, 2019
Closed
@jorgeorpinel jorgeorpinel mentioned this pull request Dec 23, 2019
Closed
@shcheklein shcheklein deleted the gf-fix_#697_status-404 branch January 22, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

engine: return HTTP 404 when Page404 component is rendered
3 participants
@iAdramelk @jorgeorpinel @shcheklein