Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Few model registry docs updates #4587

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Few model registry docs updates #4587

merged 3 commits into from
Jun 6, 2023

Conversation

aguschin
Copy link
Contributor

@aguschin aguschin commented Jun 5, 2023

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Link Check Report

There were no links to check!

Comment on lines 8 to 9
1. Log your model during the training process using [dvclive]. It is done by
calling [`log_artifact`] method.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify that it should have type=model (or show an example like live.log_artifact("path/to/model", type="model", name="mymodel"))?

Comment on lines 10 to 11
2. Edit [`dvc.yaml`](/doc/user-guide/project-structure/dvcyaml-files#artifacts)
directly.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that it needs to be added to the artifacts section?

Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple non-blocking comments.

@shcheklein shcheklein requested a deployment to dvc-org-mr-updates-eglw7rizwz2 June 6, 2023 07:45 Abandoned
@shcheklein shcheklein temporarily deployed to dvc-org-mr-updates-eglw7rizwz2 June 6, 2023 07:47 Inactive
@aguschin aguschin merged commit b533d60 into main Jun 6, 2023
@aguschin aguschin deleted the mr-updates branch June 6, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants