Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model registry docs #4423

Closed
10 of 13 tasks
Tracked by #4513
dberenbaum opened this issue Mar 22, 2023 · 14 comments
Closed
10 of 13 tasks
Tracked by #4513

Model registry docs #4423

dberenbaum opened this issue Mar 22, 2023 · 14 comments
Assignees
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints

Comments

@dberenbaum
Copy link
Contributor

dberenbaum commented Mar 22, 2023

Report

Update the model registry docs to combine all the products (GTO, DVC, Studio) into a coherent workflow and lead DVC users to this workflow. Some possible places to update:

Thoughts @aguschin @tapadipti @shcheklein?

@dberenbaum dberenbaum added the type: discussion Requires active participation to reach a conclusion. label Mar 22, 2023
@shcheklein
Copy link
Member

Yep, I like it. Two things come to my mind:

  • It should be less about GTO and MLEM. Ideally we don't even mention them. Or only as a supportive tools that solve a very specific task inside, etc. It's not because I don't like them, etc. It's because I feel it's too complicated and confusing for users too have all of them at once in all those pages.
  • I would prioritize some strong user story in the Studio docs - DVC and GTO both - are implementation details in this case.
  • DVC Use case can include reference to Studio as well

@dberenbaum dberenbaum added A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints and removed type: discussion Requires active participation to reach a conclusion. labels Apr 14, 2023
@dberenbaum
Copy link
Contributor Author

@aguschin Let's prioritize updating the DVC docs first so we have somewhere to point people with the "correct" usage today.

@dberenbaum
Copy link
Contributor Author

We have a couple people asking about/waiting on docs in discord: https://discord.com/channels/485586884165107732/1096339522553384990/1096457228258652370

@tapadipti
Copy link
Contributor

Sounds good @dberenbaum. In the Studio docs, we can restructure some of the content to unhighlight GTO, MLEM.

I would prioritize some strong user story in the Studio docs

@shcheklein Any suggestions on what user story to follow?

The current structure does follow user workflows: add models, register versions, assign stages, download files, and once we have the functionality - deploy models. Any suggestions on a better flow?

@aguschin aguschin self-assigned this Apr 18, 2023
@shcheklein
Copy link
Member

The missing part that can be useful - find the model with the right metrics before promoting / compare models.

@dberenbaum
Copy link
Contributor Author

Need to consider where to keep GTO docs

@dberenbaum
Copy link
Contributor Author

Added an item for https://dvc.org/doc/studio/get-started#manage-models

@dberenbaum
Copy link
Contributor Author

Updated to reflect #4481. @aguschin Please update anything I missed.

@dberenbaum
Copy link
Contributor Author

dberenbaum commented May 5, 2023

Thanks to @aguschin for moving this forward! After taking a look at #4516, I have a better idea of what else might be useful here:

@aguschin aguschin moved this to In Progress in DVC May 16, 2023
@aguschin aguschin added this to DVC May 16, 2023
This was referenced May 16, 2023
@dberenbaum
Copy link
Contributor Author

Added this item to the list @aguschin

@aguschin
Copy link
Contributor

aguschin commented Jun 5, 2023

Ok, another PR that updates some parts of this #4587

Except for that, what's left:

two moments to discuss - wdyt @dberenbaum?

@dberenbaum
Copy link
Contributor Author

Thanks @aguschin! I think what you covered is a good start. Once you address the things you mention, I'm fine to close this and follow up with smaller issues for anything else.

I don't think it's a release blocker, but I'd suggest spending time trying it in more frameworks will help unblock iterative/dvclive#572. I'd also consider prioritizing iterative/dvclive#586, since having a model-specific method might also help unblock things.

I would leave it out. That page unfortunately needs a lot of work, and I don't think adding another concept to it will help.

@dberenbaum
Copy link
Contributor Author

@aguschin Should we consider this closed and open follow-ups for anything remaining? Do you see any blockers for release?

@aguschin
Copy link
Contributor

No, we don't have blockers here I think.
Created a follow-up #4622
Thanks for the help on this @dberenbaum!

@github-project-automation github-project-automation bot moved this from In Progress to Done in DVC Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints
Projects
No open projects
Archived in project
Development

No branches or pull requests

4 participants