Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_model #586

Closed
dberenbaum opened this issue May 25, 2023 · 3 comments
Closed

log_model #586

dberenbaum opened this issue May 25, 2023 · 3 comments
Assignees

Comments

@dberenbaum
Copy link
Collaborator

We already have two closed issues about this 😓 , but I think we should add a log_model method that uses mlem to inspect the model artifact.

Benefits:

  • Automatically captures metadata about the model artifact that users can see in the model registry to make it more meaningful.
  • Makes model registry workflow more useful since users can deploy downstream with mlem.
  • Automatically logs it as an artifact with type=model.
  • Can support different options for how to save the model (related to Decouple dvc add from log_artifact #572).
@dberenbaum
Copy link
Collaborator Author

cc @aguschin

@aguschin
Copy link
Contributor

Ok, now I'm getting what we reserved log_model for 😅

I assume log_model should simply call mlem.api.save and ideally have the same (in practice, almost the same) args https://mlem.ai/doc/api-reference/save

This should be an easy change. Happy to take it once we're done with MR.

@dberenbaum
Copy link
Collaborator Author

In addition, it would be nice to also support an already serialized model with https://mlem.ai/doc/api-reference/import_object. In other words, it would be nice to accept either a model object or a path to a model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants