Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admons: remove for VS Code, update types #3783

Merged
merged 2 commits into from
Jul 19, 2022
Merged

admons: remove for VS Code, update types #3783

merged 2 commits into from
Jul 19, 2022

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Jul 19, 2022 •
edited
Loading

tbh, I would remove them completely - they are noisy

Originally posted by @shcheklein in #3717 (comment)

@jorgeorpinel jorgeorpinel requested a review from shcheklein July 19, 2022 19:24
@shcheklein shcheklein temporarily deployed to dvc-org-vs-code-admons-m4wz2lc July 19, 2022 19:25 Inactive
@jorgeorpinel jorgeorpinel added the A: docs Area: user documentation (gatsby-theme-iterative) label Jul 19, 2022
@shcheklein shcheklein temporarily deployed to dvc-org-vs-code-admons-m4wz2lc July 19, 2022 19:27 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review July 19, 2022 19:27
@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Jul 19, 2022 •
edited
Loading

After this we'll only have VS Code admons (without 🔥 icon) in 1) https://dvc.org/doc/command-reference and 2) https://dvc.org/doc/user-guide/experiment-management#experimentation-in-dvc
as well as other, more integrated VS Code mentions in 3) https://dvc.org/doc/install/ide-plugins, 4) https://dvc.org/doc/user-guide/what-is-dvc#core-features, and 5) https://dvc.org/doc/user-guide/experiment-management/experiments-overview#work-with-dvc-experiments-from-a-gui

#3717 remains open.

@github-actions
Copy link
Contributor

Link Check Report

There were no links to check!

@jorgeorpinel jorgeorpinel mentioned this pull request Jul 19, 2022
Closed
@jorgeorpinel jorgeorpinel self-assigned this Jul 19, 2022
@jorgeorpinel jorgeorpinel merged commit 1250f7e into main Jul 19, 2022
@jorgeorpinel jorgeorpinel deleted the vs-code/admons branch July 19, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shcheklein shcheklein shcheklein approved these changes

Assignees

@jorgeorpinel jorgeorpinel

Labels
A: docs Area: user documentation (gatsby-theme-iterative)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgeorpinel @shcheklein