-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add references to VS Code for DVC plots #3717
Comments
Yes, 💯 , I agree. |
@jorgeorpinel could you take this one? |
Sure. I started working on it and left this follow-up Q from #3718 (comment):
BTW I added it to the parent pages for now (see PR). Do we want to repeat it in those specific sub-pages too? (Note the whole Get Started needs yet another reorg...) |
Continuing discussion from #3735 (comment):
@dberenbaum these are great points. I'm just not sure whether we want to present the extension as part of DVC that transparently, when it's not really the same thing (I don't mean technically, but based on the current user experience). It's a GUI for DVC, which you still have to install separately. Rn you see this confusion in user questions like "what's the difference between DVC and the extension"? Probably a question for @mattseddon as well. We should try to decide sooner than later how should we present the extension? How do we separate and/or mix its docs with DVC's ? Thanks |
p.s. same question for @tapadipti wrt Studio. With the difference that Studio does have it's own docs (and quite extensive at this point). Thanks |
In order to answer the question we should break up users into 4 different groups:
The extension is a visual product and should need minimal documentation. I would hold off on doing things like presenting screenshots because they are going to become stale quickly. IMO the DVC docs should be driving users in group 1 & 2 towards some kind of easy trial of the extension. We'll be working on improve the trial process/time to value as part of the extension onboarding experience (one of our focuses/big stories for Q3). Personally, I think that we should initially focus on group 4 (new to DVC but not VS Code). Once we have that nailed down we can start to cater for the other 3 groups (probably prioritise 3). |
I don't think Studio has quite the same considerations because it's a commercial product intended to provide distinct value across multiple products. |
@shcheklein I think that for the DVC Get Started that's what we were shooting for (an ad). If we're mainly concerned about the current style, we can use simple For the cmd ref or guides around visualization, I suppose we can integrate the extension mentions a bit more (without admonitions). Again, if this is mainly about the styling/readability, then it's something we can address quickly -- I was more worried about larger implications (on all DVC docs) of treating the extension as part of DVC (see discussion above). |
@jorgeorpinel tbh, I would remove them completely - they are noisy: ... and do look like an ad since Studio is a commercial product. I liked some examples as Dave mentioned in the PR. I'm open to discuss any other ideas. I also agree that we should not treat Studio and VS Code the same. |
Agree with @dberenbaum. Studio works across multiple products, not just DVC. |
I'm still not sure what's wrong with advertising our own products in our own sites (which generate relevant traffic), but I'm removing most admonitions in #3783 for now. |
Addressing this issue on top of that in #3784. |
* vs-code: remove/update admons * admons: remove VS Code from start, fix types * plots: casually mention the VS Code Extension per #3717 (comment) * Update content/docs/start/experiments/visualization.md * Update content/docs/start/data-management/metrics-parameters-plots.md * plots: add link to VSCE Co-authored-by: Dave Berenbaum <[email protected]>
Feel free to reopen this ticket with a few more specific ideas of places to add VS Code Plots Dashboard mentions to. Thanks |
Report
Some places where it would help:
https://dvc.org/doc/command-reference/plots
This might be odd in a CLI ref, but for example, the current docs say:
Seems like it would be useful to at least mention that they can be visualized in VS Code, since it's a better experience than the static HTML.
https://dvc.org/doc/start/data-management/metrics-parameters-plots
https://dvc.org/doc/start/experiments/visualization
@jorgeorpinel @shcheklein Thoughts?
The text was updated successfully, but these errors were encountered: