Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to VS Code for DVC plots #3717

Closed
dberenbaum opened this issue Jul 1, 2022 · 13 comments · Fixed by #3784
Closed

Add references to VS Code for DVC plots #3717

dberenbaum opened this issue Jul 1, 2022 · 13 comments · Fixed by #3784
Assignees
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference C: start Content of /doc/start p1-important Active priorities to deal within next sprints type: discussion Requires active participation to reach a conclusion.

Comments

@dberenbaum
Copy link
Contributor

Report

Some places where it would help:

https://dvc.org/doc/command-reference/plots

This might be odd in a CLI ref, but for example, the current docs say:

DVC generates plots as static HTML webpages that can be open with a web browser. They can also be saved as SVG or PNG image files from the browser.

Seems like it would be useful to at least mention that they can be visualized in VS Code, since it's a better experience than the static HTML.

https://dvc.org/doc/start/data-management/metrics-parameters-plots

https://dvc.org/doc/start/experiments/visualization

@jorgeorpinel @shcheklein Thoughts?

@shcheklein
Copy link
Member

Yes, 💯 , I agree.

@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints C: ref Content of /doc/*-reference C: guide Content of /doc/user-guide C: start Content of /doc/start labels Jul 1, 2022
@shcheklein
Copy link
Member

@jorgeorpinel could you take this one?

@jorgeorpinel jorgeorpinel self-assigned this Jul 6, 2022
@jorgeorpinel jorgeorpinel added type: enhancement Something is not clear, small updates, improvement suggestions and removed C: guide Content of /doc/user-guide labels Jul 6, 2022
@jorgeorpinel
Copy link
Contributor

Sure. I started working on it and left this follow-up Q from #3718 (comment):

... do we add Studio links in all (or most) places where VS Code is linked from? Or just the plots-related ones for now (i.e. in the same PR) ? Lmk

https://dvc.org/doc/start/data-management/metrics-parameters-plots
https://dvc.org/doc/start/experiments/visualization

BTW I added it to the parent pages for now (see PR). Do we want to repeat it in those specific sub-pages too? (Note the whole Get Started needs yet another reorg...)

@jorgeorpinel
Copy link
Contributor

Continuing discussion from #3735 (comment):

For visualizing plots or experiments, we may want to treat VS Code as a first-class option and integrate them more seamlessly into the docs...

  1. From https://dvc.org/doc/command-reference/plots ... mention that plots can be visualized in VS Code, Studio, or static HTML. Static HTML feels like an option of last resort now
  2. A lot of https://dvc.org/doc/user-guide/experiment-management/comparing-experiments could be skipped by a user if they use VS Code
  3. In https://dvc.org/doc/start/experiments/visualization, it's not that clear how these plots are useful... Showing the image alongside other plots or compared to other experiments in VS Code could help clarify

@dberenbaum these are great points. I'm just not sure whether we want to present the extension as part of DVC that transparently, when it's not really the same thing (I don't mean technically, but based on the current user experience). It's a GUI for DVC, which you still have to install separately. Rn you see this confusion in user questions like "what's the difference between DVC and the extension"?

Probably a question for @mattseddon as well. We should try to decide sooner than later how should we present the extension? How do we separate and/or mix its docs with DVC's ? Thanks

@jorgeorpinel jorgeorpinel added C: guide Content of /doc/user-guide and removed p1-important Active priorities to deal within next sprints labels Jul 11, 2022
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jul 11, 2022

We should try to decide sooner than later how should we present the extension? How do we separate and/or mix its docs with DVC's ?

p.s. same question for @tapadipti wrt Studio. With the difference that Studio does have it's own docs (and quite extensive at this point). Thanks

@jorgeorpinel jorgeorpinel added type: discussion Requires active participation to reach a conclusion. and removed type: enhancement Something is not clear, small updates, improvement suggestions labels Jul 11, 2022
@mattseddon
Copy link
Member

mattseddon commented Jul 11, 2022

Probably a question for @mattseddon as well. We should try to decide sooner than later how should we present the extension? How do we separate and/or mix its docs with DVC's ? Thanks

In order to answer the question we should break up users into 4 different groups:

  1. Pre-existing DVC users, who use VS Code
  2. Pre-existing DVC users, who have never used VS Code
  3. New DVC users who have never used VS Code
  4. New DVC users who use VS Code

The extension is a visual product and should need minimal documentation. I would hold off on doing things like presenting screenshots because they are going to become stale quickly. IMO the DVC docs should be driving users in group 1 & 2 towards some kind of easy trial of the extension. We'll be working on improve the trial process/time to value as part of the extension onboarding experience (one of our focuses/big stories for Q3). Personally, I think that we should initially focus on group 4 (new to DVC but not VS Code). Once we have that nailed down we can start to cater for the other 3 groups (probably prioritise 3).

@dberenbaum
Copy link
Contributor Author

p.s. same question for @tapadipti wrt Studio. With the difference that Studio does have it's own docs (and quite extensive at this point). Thanks

I don't think Studio has quite the same considerations because it's a commercial product intended to provide distinct value across multiple products.

@jorgeorpinel
Copy link
Contributor

I also have a feeling that it looks like an add.... in terms of how useful it is and how disruptive it is in the document

@shcheklein I think that for the DVC Get Started that's what we were shooting for (an ad). If we're mainly concerned about the current style, we can use simple <admon type="note">s without 🔥 icons.

For the cmd ref or guides around visualization, I suppose we can integrate the extension mentions a bit more (without admonitions). Again, if this is mainly about the styling/readability, then it's something we can address quickly -- I was more worried about larger implications (on all DVC docs) of treating the extension as part of DVC (see discussion above).

@shcheklein
Copy link
Member

@jorgeorpinel tbh, I would remove them completely - they are noisy:

Screen Shot 2022-07-11 at 6 05 13 PM

... and do look like an ad since Studio is a commercial product.

I liked some examples as Dave mentioned in the PR. I'm open to discuss any other ideas.

I also agree that we should not treat Studio and VS Code the same.

@tapadipti
Copy link
Contributor

I don't think Studio has quite the same considerations because it's a commercial product intended to provide distinct value across multiple products.

Agree with @dberenbaum. Studio works across multiple products, not just DVC.

@jorgeorpinel jorgeorpinel removed the C: guide Content of /doc/user-guide label Jul 19, 2022
@jorgeorpinel jorgeorpinel changed the title Add references to VS Code (and Studio?) for DVC plots Add references to VS Code for DVC plots Jul 19, 2022
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jul 19, 2022

I'm still not sure what's wrong with advertising our own products in our own sites (which generate relevant traffic), but I'm removing most admonitions in #3783 for now.

@jorgeorpinel jorgeorpinel added the p1-important Active priorities to deal within next sprints label Jul 19, 2022
@jorgeorpinel
Copy link
Contributor

Addressing this issue on top of that in #3784.

jorgeorpinel added a commit that referenced this issue Jul 23, 2022
* vs-code: remove/update admons

* admons: remove VS Code from start, fix types

* plots: casually mention the VS Code Extension
per #3717 (comment)

* Update content/docs/start/experiments/visualization.md

* Update content/docs/start/data-management/metrics-parameters-plots.md

* plots: add link to VSCE

Co-authored-by: Dave Berenbaum <[email protected]>
@jorgeorpinel
Copy link
Contributor

any other places? (plots, table of experiments, even data? #3784 (comment)
I'm sure we could do more, but this is a really nice start #3784 (comment)

Feel free to reopen this ticket with a few more specific ideas of places to add VS Code Plots Dashboard mentions to. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference C: start Content of /doc/start p1-important Active priorities to deal within next sprints type: discussion Requires active participation to reach a conclusion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants