Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: replaced dvc run references with dvc stage and dvc exp run in dvc dag #3218

Closed
wants to merge 1 commit into from

Conversation

iesahin
Copy link
Contributor

@iesahin iesahin commented Jan 26, 2022

replaced dvc run references with dvc stage and dvc exp run

Closes #3183

@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ref-upd-g7ml4l January 26, 2022 16:03 Inactive
@iesahin iesahin force-pushed the iesahin/ref-update-dag branch from 546087a to f67f5f8 Compare January 26, 2022 16:04
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ref-upd-g7ml4l January 26, 2022 16:05 Inactive
@iesahin iesahin force-pushed the iesahin/ref-update-dag branch from f67f5f8 to 22b88ed Compare January 26, 2022 16:08
@shcheklein shcheklein temporarily deployed to dvc-org-iesahin-ref-upd-g7ml4l January 26, 2022 16:08 Inactive
@dberenbaum
Copy link
Contributor

😅 I should have seen this before I submitted #3223

@iesahin
Copy link
Contributor Author

iesahin commented Jan 27, 2022

I can close this or merge and rebase the other. WDYT @jorgeorpinel ?

@jorgeorpinel
Copy link
Contributor

If #2997 is closed this no longer seems needed (already addressed)...

Comment on lines 23 to +24
A data pipeline, in general, is a series of data processing
[stages](/doc/command-reference/run) (for example, console commands that take an
input and produce an outcome). The connections between stages are formed by the
<abbr>output</abbr> of one turning into the <abbr>dependency</abbr> of another.
A pipeline may produce intermediate data, and has a final result.
[stages](/doc/command-reference/stage) (for example, console commands that take
Copy link
Contributor

@jorgeorpinel jorgeorpinel Jan 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I see we make more run-related changes here than in https://github.com/iterative/dvc.org/pull/3223/files#diff-7b6ee3d8c0ebb9e2a9dcf9077d16fda46133fb069f3879a3c38b0653fe00e850 but updating these links seems like a separate task. Let's create an issue to decide where should the "stage" definition be (probably a guide?) and then update links throughout?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. Closed.

@iesahin
Copy link
Contributor Author

iesahin commented Jan 27, 2022

Closing this, as we merged #3223

@iesahin iesahin closed this Jan 27, 2022
@jorgeorpinel
Copy link
Contributor

Oh haha sorry, we're working on this synchronously it seems 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ref: update dvc run references in dvc dag
4 participants