Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: replace dvc run examples with dvc stage add + dvc exp run or dvc repro #2997

Closed
14 of 15 tasks
iesahin opened this issue Nov 3, 2021 · 10 comments · Fixed by #3223
Closed
14 of 15 tasks

ref: replace dvc run examples with dvc stage add + dvc exp run or dvc repro #2997

iesahin opened this issue Nov 3, 2021 · 10 comments · Fixed by #3223
Assignees
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference ✨ epic Placeholder ticket for multi-sprint direction, use story, improvement p1-important Active priorities to deal within next sprints

Comments

@iesahin
Copy link
Contributor

iesahin commented Nov 3, 2021

In the command reference, there are several examples using dvc run. Replacing these with dvc stage add may lead to clear examples.

@iesahin iesahin added C: ref Content of /doc/*-reference status: research Writing concrete steps for the issue A: docs Area: user documentation (gatsby-theme-iterative) and removed status: research Writing concrete steps for the issue C: ref Content of /doc/*-reference labels Nov 3, 2021
@jorgeorpinel jorgeorpinel changed the title ref: Replace all dvc run examples with dvc stage add + (dvc exp run or dvc repro) ref: Replace most dvc run examples with dvc stage add + (dvc exp run or dvc repro) Nov 17, 2021
@jorgeorpinel
Copy link
Contributor

ref: Add a "deprecated" notice to dvc run

I don't think it's deprecated though. I forget what the plan is but I think there's an issue about it on the core repo. Cc @dberenbaum

@iesahin
Copy link
Contributor Author

iesahin commented Nov 17, 2021

I believe, from the earlier discussions, dvc run is deprecated and may be removed in later versions. Can we have an official decision on this? @shcheklein @dberenbaum

@dberenbaum
Copy link
Contributor

Related discussions/issues:

We haven't made progress towards deprecation, but I think we have at least agreed on emphasizing stage add. I have no objection to replacing the examples.

@iesahin iesahin self-assigned this Nov 30, 2021
@jorgeorpinel jorgeorpinel added the ✨ epic Placeholder ticket for multi-sprint direction, use story, improvement label Dec 7, 2021
@jorgeorpinel
Copy link
Contributor

Could the DVC team finish the cmd ref updates related to this @dberenbaum ?

@iesahin maybe we should just double check no other docs still use run unnecessrily.

@jorgeorpinel jorgeorpinel added the p1-important Active priorities to deal within next sprints label Jan 14, 2022
@dberenbaum dberenbaum added this to DVC Jan 15, 2022
@dberenbaum dberenbaum moved this to Backlog in DVC Jan 15, 2022
Repository owner moved this from Backlog to Done in DVC Jan 27, 2022
@jorgeorpinel jorgeorpinel changed the title ref: Replace most dvc run examples with dvc stage add + (dvc exp run or dvc repro) ref: replace dvc run examples with dvc stage add + dvc exp run or dvc repro Jan 27, 2022
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Jan 27, 2022

Looks like a few tasks may still be pending or need discussing a little. Reopening for now...

I'll update the check boxes in the description as needed. ✔️

@jorgeorpinel jorgeorpinel reopened this Jan 27, 2022
Repository owner moved this from Done to Todo in DVC Jan 27, 2022
@jorgeorpinel
Copy link
Contributor

UPDATE: Looks like it's just about https://dvc.org/doc/command-reference/gc but as long as we haven't actually deprecated run we can leave that link (as well as the one in https://dvc.org/doc/command-reference/status). So never mind 😬

Repository owner moved this from Todo to Done in DVC Jan 27, 2022
@jorgeorpinel
Copy link
Contributor

Do we have an issue to do the same for guides and use cases though? ⌛

@dberenbaum
Copy link
Contributor

@jorgeorpinel I'm not sure about guides and use cases, but I did take a look at getting started, and it seems like it will require more of an overhaul than just replacing text. I think it would have to be a dedicated project for someone to update it.

@jorgeorpinel
Copy link
Contributor

I did take a look at getting started, and it seems like it will require more of an overhaul than just replacing text

Yeah let's leave that to @iesahin for now then?

BTW I did find an existing issue that's related so I'm updating it to follow up on all this: #2076

@iesahin
Copy link
Contributor Author

iesahin commented Jan 31, 2022

I took over #2076. We can discuss the remaining parts there. This issue was specific to REF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: ref Content of /doc/*-reference ✨ epic Placeholder ticket for multi-sprint direction, use story, improvement p1-important Active priorities to deal within next sprints
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants