-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: missing adds --jobs
#3199
ref: missing adds --jobs
#3199
Conversation
--jobs
option.add
: Describe missing --jobs
option.
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
add
: Describe missing --jobs
option.adds --jobs
- `-j <number>`, `--jobs <number>` - Only used if `--to-remote` is also passed. | ||
Parallelism level for DVC to upload data to remote storage. The default value | ||
is 4 \* cpu_count(). For SSH remotes, the default is 4. Note that the default | ||
value can be set using the jobs config option with dvc remote modify. Using | ||
more jobs may speed up the operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For closer consistency with other refs that have this option:
- `-j <number>`, `--jobs <number>` - Only used if `--to-remote` is also passed. | |
Parallelism level for DVC to upload data to remote storage. The default value | |
is 4 \* cpu_count(). For SSH remotes, the default is 4. Note that the default | |
value can be set using the jobs config option with dvc remote modify. Using | |
more jobs may speed up the operation. | |
- `-j <number>`, `--jobs <number>` - | |
parallelism level for DVC to transfer data when using `--to-remote`. The default value | |
is `4 \* cpu_count()`. For SSH remotes, the default is `4`. Using | |
more jobs may speed up the operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Committed. I removed "Note that the default value can be set using the jobs config option with dvc remote modify" too. It's a good note though, but it kind of overcomplicates the already-complicated description. I wonder if there's a better place to comment on this... ⌛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed "Note that the default value can be set using the jobs config option...
Maybe we should change the text (in all refs) to something like "The default is 4*cpu (can be set with dvc remote modify jobs
) :...
Linked to https://dvc.org/doc/command-reference/remote/modify#available-parameters-for-all-remotes
Co-authored-by: Restyled.io <[email protected]>
- `-j <number>`, `--jobs <number>` - parallelism level for DVC to transfer data | ||
when using `--to-remote`. The default value is `4 \* cpu_count()`. For SSH | ||
remotes, the default is `4`. Using more jobs may speed up the operation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if --jobs
also has this same effect in import-url --to-remote
. Currently it only refers to downloading the target data. @dberenbaum or @efiop, do you know? Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--jobs
affects the uploading
when using dvc import-url --to-remote
so the description should be updated. This also affects dvc update
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this Q to #3233
I found another spot missing add
mention...
@daavoo thanks again for this. Mind also completing the list of commands that have |
Done. |
Co-authored-by: Restyled.io <[email protected]>
* Update add.md * Restyled by prettier (#3200) Co-authored-by: Restyled.io <[email protected]> * Update add.md * Restyled by prettier (#3201) Co-authored-by: Restyled.io <[email protected]> * Update content/docs/command-reference/add.md * Restyled by prettier (#3227) Co-authored-by: Restyled.io <[email protected]> * Add missing commands with `--jobs`. * Update content/docs/command-reference/remote/modify.md * Restyled by prettier (#3234) Co-authored-by: Restyled.io <[email protected]> Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Jorge Orpinel <[email protected]>
jobs
config option