-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive synopsis Fix #2024 #3140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far!
One idea that comes to mind is having our |
Yeah, that's the idea. But, I am having a little bit issue with adding the HTML |
Feel free to message me in Slack if you want to discuss possible solutions! |
@iterative/docs
These are the assumptions taken and these need to be converted into guidelines/rules. |
It's just the output from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I did notice some minor things, but I think we could still merge this and fix them on a later iteration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Reading through all of the comments, there is still a couple things to do but we could create a issue listing the rest of the tasks to do later. If everyone else agrees, I think we could merge this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely looks good enough to me to be merged as a first iteration!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Good stuff with the prism hook - less code == better sleep :)
Two small things. First, could we please move icon a bit down to align it better with the bullets?
And please still review and resolve the existing comments (it's totally fine if you think that it's not the right time to address, or you want to keep certain things the way it is, but it's a good practice to react and say that we are moving forward).
Thanks @yathomasi ! |
* added html to react * utility html to react parser * using code component and minor changes * added args linker plugin to add ids to options * removed hover css * fixed selection logic * removed html to react dependency * added anchor icon in front of list items * update to fix only use args from square brackets * show anchor icon on list hover * added outline * linkified whole arguments with parameters * allowed two level of square brackets nestings * made link icon visible on focus * updated command linker to add hash links for args * fix codeclimate * added id attribute to respective inline code block * added id to list and paragraph instead * updated code component to use all props * added ids for argument to respective code block * used lodash has property for key check * replaced custom component with prism hook * generalized the arg regex * updated command linker * reduced line for code climate fix * used same link icon source for consistency * added pathname params * code fixes * aligned the icons
Feature mentioned on #2024 .
We may not actually need the different/special way to specify command arguments because current enclosing with enclosing brackets should be fine. But, we need to define some set of rules/guidelines so that we are consistent throughout the documentation and also it's would be great to define the parser.
define some guidelines for arguments and options(no need as it's defined by argsparse on similar pattern)#
tags to the argumentsid
for anchor tags@iterative/websites @shcheklein @iterative/docs
After merge:
--out
option ofdvc import
," to just "usedvc import --out
."