Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: correct dvctable highlighter #2781

Merged
merged 4 commits into from
Sep 2, 2021
Merged

ref: correct dvctable highlighter #2781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b64c3d4
ref: correct dvctable highlighter
jorgeorpinel Sep 1, 2021
0e47426
Merge branch 'master' into ref/dvctable
jorgeorpinel Sep 2, 2021
b1252e1
ref: format exp show tables in exp remove
jorgeorpinel Sep 2, 2021
9046563
guide: format exp show tables in Cleaning Exps
jorgeorpinel Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions content/docs/command-reference/exp/remove.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ $ dvc exp remove e41d5b4 split16
$ dvc exp show --include-params=train.min_split --no-pager
```

```table
```dvctable
┏━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━━━━┓
┃ Experiment ┃ Created ┃ State ┃ avg_prec ┃ roc_auc ┃ train.min_split ┃
┃ neutral:**Experiment** ┃ neutral:**Created** ┃ neutral:**State** ┃ metric:**avg_prec** ┃ metric:**roc_auc** ┃ metric:**train.min_split** ┃
Comment on lines -88 to +90
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we highlight the header (colorize params, metrics, etc)?

Sanity checked in https://dvc-org-ref-dvctable-ojpnqwjsg.herokuapp.com/doc/command-reference/exp/remove#examples:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scroll bar isn't ideal but it's a problem in most exp show tables now (it looked better when they were images but wasn't copy-pasteable).

┡━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━━━━━┩
│ workspace │ - │ - │ 0.57553 │ 0.94652 │ 2 │
│ master │ Aug 02, 2021 │ - │ 0.53252 │ 0.9107 │ 2 │
Expand Down
12 changes: 6 additions & 6 deletions content/docs/user-guide/experiment-management/cleaning-experiments.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ $ dvc exp show --all-branches

```dvctable
┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━┓
┃ white:**Experiment** ┃ white:**Created** ┃ yellow:**acc** ┃ blue:**model.conv_units** ┃
┃ neutral:**Experiment** ┃ neutral:**Created** ┃ metric:**acc** ┃ param:**model.conv_units** ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━┩
Comment on lines 79 to 82
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked in https://dvc-org-ref-dvctable-ojpnqwjsg.herokuapp.com/doc/user-guide/experiment-management/cleaning-experiments.

image

│ workspace │ - │ - │ 64 │
│ cnn-48 │ 09:11 AM │ 0.9131 │ 48 │
Expand Down Expand Up @@ -106,7 +106,7 @@ The resulting `dvc exp show` table is as the following:

```dvctable
┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━┓
┃ Experiment ┃ Created ┃ acc ┃ model.conv_units ┃
┃ neutral:**Experiment** ┃ neutral:**Created** ┃ metric:**acc** ┃ metric:**model.conv_units** ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━┩
│ workspace │ - │ - │ 64 │
│ cnn-48 │ 09:11 AM │ 0.9131 │ 48 │
Expand All @@ -127,7 +127,7 @@ $ dvc exp show --all-tags

```dvctable
┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┓
┃ Experiment ┃ acc ┃ model.conv_units ┃
┃ neutral:**Experiment** ┃ metric:**acc** ┃ metric:**model.conv_units** ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━┩
│ workspace │ 0.9067 │ 16 │
│ ├── 2fc4f81 [exp-a1b3c4]│ 0.9037 │ 48 │
Expand All @@ -147,7 +147,7 @@ $ dvc exp show --all-tags

```dvctable
┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━━┓
┃ Experiment ┃ acc ┃ model.conv_units ┃
┃ neutral:**Experiment** ┃ metric:**acc** ┃ metric:**model.conv_units** ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━━┩
│ workspace │ 0.9067 │ 16 │
│ my-experiments │ 0.9067 │ 16 │
Expand Down Expand Up @@ -222,7 +222,7 @@ $ dvc exp show

```dvctable
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━┓
┃ Experiment ┃ Created ┃ param ┃
┃ neutral:**Experiment** ┃ neutral:**Created** ┃ metric:**param** ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━┩
│ workspace │ - │ - │
│ 04abbb7 │ Jul 21, 2021 │ - │
Expand All @@ -240,7 +240,7 @@ $ dvc exp show

```dvctable
┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━┓
┃ Experiment ┃ Created ┃ param ┃
┃ neutral:**Experiment** ┃ neutral:**Created** ┃ metric:**param** ┃
┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━┩
│ workspace │ - │ - │
│ 04abbb7 │ Jul 21, 2021 │ - │
Expand Down