ref: correct dvctable highlighter #2781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
reviewed
Sep 1, 2021
shcheklein
approved these changes
Sep 1, 2021
jorgeorpinel
temporarily deployed
to
dvc-org-ref-dvctable-ojpnqwjsg
jorgeorpinel
commented
Sep 2, 2021
Comment on lines
-88
to
+90
| ```table | ||
| ```dvctable | ||
| ┏━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━━━━┓ | ||
| ┃ Experiment ┃ Created ┃ State ┃ avg_prec ┃ roc_auc ┃ train.min_split ┃ | ||
| ┃ neutral:**Experiment** ┃ neutral:**Created** ┃ neutral:**State** ┃ metric:**avg_prec** ┃ metric:**roc_auc** ┃ metric:**train.min_split** ┃ |
There was a problem hiding this comment.
should we highlight the header (colorize params, metrics, etc)?
Sanity checked in https://dvc-org-ref-dvctable-ojpnqwjsg.herokuapp.com/doc/command-reference/exp/remove#examples:
There was a problem hiding this comment.
The scroll bar isn't ideal but it's a problem in most exp show tables now (it looked better when they were images but wasn't copy-pasteable).
jorgeorpinel
force-pushed
the
ref/dvctable
branch
from
d866b02 to
9046563
Compare
jorgeorpinel
commented
Sep 2, 2021
Comment on lines
79
to
82
| ```dvctable | ||
| ┏━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━┳━━━━━━━━┳━━━━━━━━━━━━━━━━━━┓ | ||
| ┃ white:**Experiment** ┃ white:**Created** ┃ yellow:**acc** ┃ blue:**model.conv_units** ┃ | ||
| ┃ neutral:**Experiment** ┃ neutral:**Created** ┃ metric:**acc** ┃ param:**model.conv_units** ┃ | ||
| ┡━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━╇━━━━━━━━╇━━━━━━━━━━━━━━━━━━┩ |
There was a problem hiding this comment.
jorgeorpinel
temporarily deployed
to
dvc-org-ref-dvctable-ojpnqwjsg
karajan1001
pushed a commit
to karajan1001/dvc.org
that referenced
this pull request
Sep 29, 2021
* ref: correct dvctable highlighter * ref: format exp show tables in exp remove * guide: format exp show tables in Cleaning Exps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.