Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format: lint all files #2624

Merged
merged 3 commits into from
Jul 16, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
> You may disregard these recommendations if you used the **Edit on GitHub** button from dvc.org to improve a doc in place.
casperdcl marked this conversation as resolved.
Show resolved Hide resolved
> You may disregard these recommendations if you used the **Edit on GitHub**
> button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the [Contributing to the Documentation](https://dvc.org/doc/user-guide/contributing/docs) list if you make any substantial changes to the documentation or JS engine.
❗ Please read the guidelines in the
[Contributing to the Documentation](https://dvc.org/doc/user-guide/contributing/docs)
list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention `Fix #issue` (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.
🐛 Please make sure to mention `Fix #issue` (if applicable) in the description
of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to [allow us](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to edit your branch when creating the PR.
Please choose to
[allow us](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏
3 changes: 0 additions & 3 deletions .github/workflows/link-check-all.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,14 @@ on:
workflow_dispatch:
schedule:
- cron: '0 0 * * *'

jobs:
run:
name: Link Check All
runs-on: ubuntu-latest
env:
NODE_OPTIONS: '--max-http-header-size=65536'

steps:
- uses: actions/checkout@v2

- name: Run Link Check
uses: 'iterative/[email protected]'
with:
Expand Down
14 changes: 5 additions & 9 deletions .github/workflows/link-check-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,32 +4,29 @@ name: Check new links against deployment
on:
- deployment
- deployment_status

jobs:
run:
name: Initialize
runs-on: ubuntu-latest
if: github.event.deployment.ref != 'master' && github.event.deployment_status.state == 'success'

if:
github.event.deployment.ref != 'master' &&
github.event.deployment_status.state == 'success'
steps:
- uses: actions/checkout@v2

- id: build_check
uses: LouisBrunner/[email protected]
with:
token: ${{ secrets.GITHUB_TOKEN }}
name: Report
status: queued

- name: Run Link Check
id: check
uses: 'iterative/[email protected]'
uses: iterative/[email protected]
with:
diff: true
configFile: 'config/link-check/config.yml'
configFile: config/link-check/config.yml
rootURL: '${{ github.event.deployment.payload.web_url }}'
output: checksAction

- uses: LouisBrunner/[email protected]
if: ${{ success() }}
with:
Expand All @@ -38,7 +35,6 @@ jobs:
status: completed
conclusion: ${{ steps.check.outputs.conclusion }}
output: ${{ steps.check.outputs.output }}

- uses: LouisBrunner/[email protected]
if: ${{ failure() }}
with:
Expand Down
1 change: 0 additions & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
.cache/
.github
public/
8 changes: 2 additions & 6 deletions .restyled.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,6 @@ restylers:
'--print-width=80',
'--tab-width=2',
'--use-tabs=false',
'--prose-wrap=always',
'--prose-wrap=always'
]
include:
- './*.{js,md}'
- 'pages/**/*.js'
- 'content/**/*.md'
- 'src/**/*.js'
include: ['**/*.{js,json,md,yaml,yml}']
Copy link
Contributor

@jorgeorpinel jorgeorpinel Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From iterative/cml.dev#60 (comment)

any reason not to do this?

Yes, it's a white list. For example when you run the dev server there's a .cache/ folder with lots of .js files (also node_modules/ and public/); there can be .vscode/extensions.json in your repo; etc.

Is there a reason to do this? 🙂

Copy link
Contributor Author

@casperdcl casperdcl Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a restyled bot config file, @jorgeorpinel so that's all uncommitted irrelevance AFAIK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so that's all uncommitted irrelevance AFAIK. - your point that it'll be analyzing only changed files?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would double check that this is true

Copy link
Contributor Author

@casperdcl casperdcl Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the restyled bot works online - it never sees our local mess.