Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format: lint all files #2624

Merged
merged 3 commits into from
Jul 16, 2021
Merged

format: lint all files #2624

merged 3 commits into from
Jul 16, 2021

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Jul 12, 2021

Lint all *.js,json,md,yaml,yml.

From iterative/cml.dev#60 (review)

@shcheklein shcheklein temporarily deployed to dvc-org-lint-more-hfk42exdya7m July 12, 2021 20:38 Inactive
@casperdcl casperdcl self-assigned this Jul 12, 2021
include:
- './*.{js,md}'
- 'pages/**/*.js'
- 'content/**/*.md'
- 'src/**/*.js'
include: ['**/*.{js,json,md,yaml,yml}']
Copy link
Contributor

@jorgeorpinel jorgeorpinel Jul 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From iterative/cml.dev#60 (comment)

any reason not to do this?

Yes, it's a white list. For example when you run the dev server there's a .cache/ folder with lots of .js files (also node_modules/ and public/); there can be .vscode/extensions.json in your repo; etc.

Is there a reason to do this? 🙂

Copy link
Contributor Author

@casperdcl casperdcl Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a restyled bot config file, @jorgeorpinel so that's all uncommitted irrelevance AFAIK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so that's all uncommitted irrelevance AFAIK. - your point that it'll be analyzing only changed files?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would double check that this is true

Copy link
Contributor Author

@casperdcl casperdcl Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the restyled bot works online - it never sees our local mess.

@shcheklein shcheklein temporarily deployed to dvc-org-lint-more-hfk42exdya7m July 14, 2021 13:50 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants