-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format: lint all files #2624
format: lint all files #2624
Conversation
include: | ||
- './*.{js,md}' | ||
- 'pages/**/*.js' | ||
- 'content/**/*.md' | ||
- 'src/**/*.js' | ||
include: ['**/*.{js,json,md,yaml,yml}'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From iterative/cml.dev#60 (comment)
any reason not to do this?
Yes, it's a white list. For example when you run the dev server there's a .cache/ folder with lots of .js files (also node_modules/ and public/); there can be .vscode/extensions.json in your repo; etc.
Is there a reason to do this? 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a restyled bot config file, @jorgeorpinel so that's all uncommitted irrelevance AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so that's all uncommitted irrelevance AFAIK.
- your point that it'll be analyzing only changed files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would double check that this is true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the restyled bot works online - it never sees our local mess.
Lint all
*.js,json,md,yaml,yml
.From iterative/cml.dev#60 (review)