Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: exp Examples, etc. #2259
ref: exp Examples, etc. #2259
Changes from all commits
c975a86
178b110
77b96f1
a0ccd63
7f41d83
baa601c
88686f3
fb37dcd
70e1cbe
a204f41
f0187a0
0604483
e62e1e0
22ec5d6
ae55ca5
759b12f
e3f01b3
e946710
ffde787
c6af90f
c2713c4
d2a389f
7b442d5
a99f821
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to actually push some experiments to the repo to support this? I don't it will work right now, which could cause confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to one of the exp-specific repos you published instead (for the next iteration). Do they already have some exps up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't pushed any experiments since they need a data remote to save the experiment data. However, there is a read-only remote associated with
example-get-started
, so I could add some there. Let me know what you think.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, having some exps in there would be nice. That remote is read-only in it's HTTP form but you can use the S3 config to upload stuff as you probably already know from modifying the generator script 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I just pushed some experiments up to https://github.com/iterative/example-get-started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks! 🙏