-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: exp Examples, etc. #2259
ref: exp Examples, etc. #2259
Conversation
623a879
to
7f41d83
Compare
Removing draft status. While not complete yet, it's getting big as usual... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a few examples that need to be cleaned up, but otherwise in pretty good shape.
You can also list experiments in a any DVC repo with `dvc exp list`: | ||
|
||
```dvc | ||
$ dvc exp list --all [email protected]:iterative/example-get-started.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to actually push some experiments to the repo to support this? I don't it will work right now, which could cause confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe to one of the exp-specific repos you published instead (for the next iteration). Do they already have some exps up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't pushed any experiments since they need a data remote to save the experiment data. However, there is a read-only remote associated with example-get-started
, so I could add some there. Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, having some exps in there would be nice. That remote is read-only in it's HTTP form but you can use the S3 config to upload stuff as you probably already know from modifying the generator script 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, I just pushed some experiments up to https://github.com/iterative/example-get-started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks! 🙏
> Notice that experiments run as a series don't build up on each other. They are | ||
> all based on `HEAD`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is meant by this? If you run experiments in your workspace (not with --temp
), they will make changes that will get picked up by the subsequent experiment. For example, if you follow this example and then run dvc exp run -S prepare.split=0.3
, then featurize.max_features
will be 2000
in that experiment even though it is 1000
in HEAD
.
Co-authored-by: Dave Berenbaum <[email protected]>
Co-authored-by: Dave Berenbaum <[email protected]>
Co-authored-by: Dave Berenbaum <[email protected]>
Restyle ref: exp Examples, etc.
Hey @dberenbaum thanks for the reviews. You expressed approval in #2259 (review) and all the details have been addressed. Mind formally approving? Can't merge this otherwise 😢 Ty |
Base examples for all refs (except index) — will be improved in the next iteration using @dberenbaum's example repos (:
Fixes to explanations that were merged with inaccuracies
Change base to
master
when ref: remaining exp cmds (branch,res,list,push,pull,gc) #2243 is merged.