Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review all dvc add examples throughout docs #1605 #1608

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Review all dvc add examples throughout docs #1605 #1608

merged 4 commits into from
Jul 22, 2020

Conversation

sahilbhosale63
Copy link
Contributor

@sahilbhosale63 sahilbhosale63 commented Jul 21, 2020 •
edited by jorgeorpinel
Loading

Made changes to other instances of the dvc add command in the docs.

Per #1605 (comment)

@jorgeorpinel jorgeorpinel mentioned this pull request Jul 21, 2020
Closed
20 tasks
jorgeorpinel
jorgeorpinel approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect 🙂

Just one error:

content/docs/start/data-versioning.md Outdated
$ dvc add data/data.xml
$ dvc add data/data.xml data/.gitignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dvc add .gitignore ?

Nope, that's wrong, please revert. This line was fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jorgeorpinel jorgeorpinel merged commit b4d6cc3 into iterative:master Jul 22, 2020
@weekly-digest weekly-digest bot mentioned this pull request Jul 26, 2020
Closed
@jorgeorpinel jorgeorpinel mentioned this pull request Dec 22, 2020
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgeorpinel jorgeorpinel jorgeorpinel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahilbhosale63 @jorgeorpinel