-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review all dvc add examples throughout docs #1255 #1605
Conversation
Please do not use that special word @sahilbhosale63, because the entire issue would be closed when/if this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start. I left some specific comments on what to do in the 2 instances you found (just remove all the output, it will be easier to maintain these docs in the future this way) 👇
Other than that, I think there are other instances of $ dvc add
that probably need some updates. Maybe not in the command or it's output themselves, but in related text of code blocks following. HOWEVER, these secondary updates are somewhat out of scope, since there's a separate checkbox in #1255 for that, so we can leave it for another separate PR if you prefer. Let's just double check that there's no other instances that actually need changes in the command itself or its output.
UPDATE: I looked over the entire 33 instances of
^ For all these it's necessary to follow the entire example/context in question to determine these questions, and make the necessary updates. |
Thanks @sahilbhosale63 ! |
Review all dvc add examples throughout docs #1605
#1255: Reviewed all the dvc add examples throughout docs. This issue is mentioned under Next priorities on GitHub.