Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: update push deps example #1591

Merged
merged 5 commits into from
Jul 29, 2020
Merged

cmd: update push deps example #1591

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc003c1
removed Dvcfile
imhardikj Jul 18, 2020
ec42aa9
updates
imhardikj Jul 18, 2020
db08e42
dvc dag use
imhardikj Jul 21, 2020
647db55
cat dvc.yaml
imhardikj Jul 21, 2020
8d26783
updates
imhardikj Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions content/docs/command-reference/push.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,11 +181,11 @@ One could do a simple `dvc push` to share all the data, but what if you only
want to upload part of the data?

```dvc
$ dvc push --with-deps matrix-train.p.dvc
$ dvc push --with-deps test-posts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to rewrite the example above, the project structure for this command to make sense?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, why do change the stage name here, intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rewrite the example above, the project structure for this command to make sense

Yes! It was also done in the complementary PR. Both are merged, please check in https://dvc.org/doc/command-reference/push#example-with-dependencies

why do change the stage name here, intentional?

Intentional. I came up with these new names. But now that you mention it matrix-train would've been the obvious choice here 🤦

Copy link
Contributor

@jorgeorpinel jorgeorpinel Jul 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait no, that't the name of the next stage. That's why I came up with test-posts.


... Do some work based on the partial update

$ dvc push --with-deps model.p.dvc
$ dvc push --with-deps matrix-train
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here - why do we need to change the stage name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think model is a good stage name.


... Push the rest of the data

Expand All @@ -194,11 +194,11 @@ $ dvc status --cloud
Data and pipelines are up to date.
```

We specified a stage in the middle of this pipeline (`matrix-train.p.dvc`) with
the first push. `--with-deps` caused DVC to start with that `.dvc` file, and
search backwards through the pipeline for data files to upload.
We specified a stage in the middle of this pipeline (`test-posts`) with the
first push. `--with-deps` caused DVC to start with that `.dvc` file, and search
backwards through the pipeline for data files to upload.

Because the `model.p.dvc` stage occurs later (it's the last one), its data was
Because the `matrix-train` stage occurs later (it's the last one), its data was
not pushed. However, we then specified it in the second push, so all remaining
data was uploaded.

Expand Down