cmd: update push deps example #1591
Conversation
imhardikj
changed the title
|
@jorgeorpinel I have removed |
jorgeorpinel
changed the title
|
@jorgeorpinel updated the example |
jorgeorpinel
changed the title
There was a problem hiding this comment.
Approved, but we need to wait until #1584 (comment) is merged before merging this one.
|
hey, thanks @imhardikj , but I still see |
| @@ -181,11 +181,11 @@ One could do a simple `dvc push` to share all the data, but what if you only | |||
| want to upload part of the data? | |||
|
|
|||
| ```dvc | |||
| $ dvc push --with-deps matrix-train.p.dvc | |||
| $ dvc push --with-deps test-posts | |||
There was a problem hiding this comment.
we need to rewrite the example above, the project structure for this command to make sense?
There was a problem hiding this comment.
also, why do change the stage name here, intentional?
There was a problem hiding this comment.
rewrite the example above, the project structure for this command to make sense
Yes! It was also done in the complementary PR. Both are merged, please check in https://dvc.org/doc/command-reference/push#example-with-dependencies
why do change the stage name here, intentional?
Intentional. I came up with these new names. But now that you mention it matrix-train would've been the obvious choice here 🤦
There was a problem hiding this comment.
Wait no, that't the name of the next stage. That's why I came up with test-posts.
|
|
||
| ... Do some work based on the partial update | ||
|
|
||
| $ dvc push --with-deps model.p.dvc | ||
| $ dvc push --with-deps matrix-train |
There was a problem hiding this comment.
same here - why do we need to change the stage name?
There was a problem hiding this comment.
I don't think model is a good stage name.
Sorry that wsa confusing but I set it up that way: someone else was working on that part of the code so I asked Hardik to leave it alone. Now both PRs are merged and |
Close #1445 by addressing the last pending checkbox: