-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs/start/experiments.md #1511
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! please, take a look ...at this moment it's quite repetitive and should be restructured a bit.
I tried omitting certain parts which were probably too much detail for someone getting started. |
Hey @utkarshsingh99, I'll take over reviewing this PR. BTW, let's do just 1 PR at a time, please β so I'll focus on this one only for now (you have #1494 also).
It is/was all inside that expandable section. The paragraph explaining the options is repetitive with the later note about cache: false right now. I left specific comments about how to fix that though. Also, I deployed this to https://dvc-landing-patch13-q0vmux9res.herokuapp.com/doc/start/experiments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one last small suggestion left βοΈ
β Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
π Please make sure to mention
Fix #issue
(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. π
Fix #1508
@shcheklein @jorgeorpinel