Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get-started: cache: false explanation #1508

Closed
skshetry opened this issue Jun 29, 2020 · 9 comments · Fixed by #1511
Closed

get-started: cache: false explanation #1508

skshetry opened this issue Jun 29, 2020 · 9 comments · Fixed by #1511
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: start Content of /doc/start good first issue Good for newcomers help wanted Contributors especially welcome type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@skshetry
Copy link
Member

> `cache: false` means that those file are small enough and versioned directly
> with Git.

The cache: false is an intention to do what's explained, it's not what it means though.

@shcheklein
Copy link
Member

@skshetry not sure I follow, could you elaborate please? (or even better suggest the way you think it should be).

@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) triage labels Jun 29, 2020
@skshetry
Copy link
Member Author

skshetry commented Jun 29, 2020

Something like this?

With cache: false, caching of the output is skipped by DVC and is usually done either if the file are small enough or needs to be versioned directly with git.

@shcheklein
Copy link
Member

ah, I see ... to be honest, I think it's fine to keep it simple, in 99.9% cases this is cache false means that those files are indeed tracked directly with Git. I haven't see any other cases yet at least.

We can do something like "In this case cache: false means that those files are small enough to be versioned with Git".

@skshetry
Copy link
Member Author

Still, cache: false does not mean that those files are small enough or is versioned by Git. Probably, it's one of the usecase of it, but it is not what it means.

@shcheklein
Copy link
Member

Still, cache: false does not mean that those files are small enough or is versioned by Git. Probably, it's one of the usecase of it, but it is not what it means.

yep, still in this case it's totally fine since we talk about metrics and plots file specifically - Get started is not command reference - no need to be mathematically precise.

@skshetry
Copy link
Member Author

skshetry commented Jun 29, 2020

@shcheklein, it's under "Expand to see what happens under the hood", so, we can explain that detail, or we could rephrase it as,

With cache: false, DVC skips caching the output as we want "metrics.json" to be versioned by Git.

Also, I see that Data Pipelines explains all the flags, but "Experiments" does not explain what -M and --plots-no-cache is, and why -M is being used instead of -m and --plots-no-cache instead of --plots.

@shcheklein
Copy link
Member

@skshetry I don't have a strong opinion on this - to my mind both ways (the current one and the one you suggested) are fine for this section and the meaning more or less the same. So, feel free to make a PR. The essence is the same - we version files directly with Git since, and we do this usually when they are small enough. I would still try to keep language simple and mention that files are small though.

Also, I see that Data Pipelines explains all the flags, but "Experiments" does not explain what

I would say it's a bit of a legacy that we explain flags in such details. But good point, and we can add that info if it's hidden.

@shcheklein shcheklein added type: enhancement Something is not clear, small updates, improvement suggestions good first issue Good for newcomers help wanted Contributors especially welcome and removed triage labels Jun 29, 2020
@utkarshsingh99
Copy link
Contributor

If you are going ahead with this change, can I take this up?

@shcheklein
Copy link
Member

@utkarshsingh99 absolutely! feel free to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: start Content of /doc/start good first issue Good for newcomers help wanted Contributors especially welcome type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants