-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add abbrs within details #1359
Conversation
This feature broke at some point in the past and all these were removed. The feature has since been fixed, so these are safe to re-add.
…o re-add-abbrs-within-details
You are out of testsChoose a plan to resume monitoring your Sites and Pull Requests. If you need help, check the Manage Your Plan and Test Usage guide. |
We don't have a tooltip match for "cache directory"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woot woot thanks for fixing this old one @rogermparent! It's good not to have this limitation any more.
I would just double check about
- Undo also 6d642ef.
That commit is old but if you look for that note on local remotes throughout the docs now, you may find it in more places than the ones modified in there.
Thanks!
Thanks for pointing that out! I'll recheck it. |
I think I missed the correct context originally when editing it, and committed it because it looked like any other abbr addition.
Thanks @rogermparent 👍 |
Having
abbr
s indetails
used to break them, leading to #510.At some point since then, the issue was fixed and
abbr
works withindetails
with no problem, even in quotes.This branch re-adds the
abbr
s removed in #510.I think this also fixes #510, unless I missed something from the list or there are other docs to re-introduce this to.
Uses the list from this comment
<abbr>
to term "project" in the first<details>
section of static/docs/get-started/configure.md, for now removed in ce3d940.<abbr>
in tags static/docs/get-started/add-files.md removed temporarily in ed4062e.