Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add abbrs within details #1359

Merged
merged 10 commits into from
May 26, 2020
Merged

Re-add abbrs within details #1359

merged 10 commits into from
May 26, 2020

Conversation

rogermparent
Copy link
Contributor

@rogermparent rogermparent commented May 25, 2020

Having abbrs in details used to break them, leading to #510.

At some point since then, the issue was fixed and abbr works within details with no problem, even in quotes.

This branch re-adds the abbrs removed in #510.
I think this also fixes #510, unless I missed something from the list or there are other docs to re-introduce this to.

Uses the list from this comment

  • We should add <abbr> to term "project" in the first <details> section of static/docs/get-started/configure.md, for now removed in ce3d940.
  • Re-add <abbr> in tags static/docs/get-started/add-files.md removed temporarily in ed4062e.
  • Undo also 6d642ef.
  • And d28add6

jorgeorpinel and others added 6 commits May 25, 2020 13:12
@shcheklein shcheklein temporarily deployed to dvc-landing-re-add-abbr-6z4umv May 25, 2020 23:27 Inactive
@shcheklein shcheklein requested a review from jorgeorpinel May 25, 2020 23:28
@calibre-analytics
Copy link

You are out of tests

Choose a plan to resume monitoring your Sites and Pull Requests. If you need help, check the Manage Your Plan and Test Usage guide.

@rogermparent rogermparent temporarily deployed to dvc-landing-re-add-abbr-6z4umv May 25, 2020 23:46 Inactive
@rogermparent rogermparent temporarily deployed to dvc-landing-re-add-abbr-6z4umv May 26, 2020 00:18 Inactive
We don't have a tooltip match for "cache directory"
@rogermparent rogermparent temporarily deployed to dvc-landing-re-add-abbr-6z4umv May 26, 2020 02:46 Inactive
Copy link
Contributor

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot woot thanks for fixing this old one @rogermparent! It's good not to have this limitation any more.

I would just double check about

That commit is old but if you look for that note on local remotes throughout the docs now, you may find it in more places than the ones modified in there.

@rogermparent
Copy link
Contributor Author

Woot woot thanks for fixing this old one @rogermparent! It's good not to have this limitation any more.

Thanks!

That commit is old but if you look for that note on local remotes throughout the docs now, you may find it in more places than the ones modified in there.

Thanks for pointing that out! I'll recheck it.

@rogermparent rogermparent had a problem deploying to dvc-landing-re-add-abbr-6z4umv May 26, 2020 20:52 Failure
I think I missed the correct context originally when editing it, and committed
it because it looked like any other abbr addition.
@rogermparent rogermparent temporarily deployed to dvc-landing-re-add-abbr-6z4umv May 26, 2020 21:01 Inactive
@shcheklein
Copy link
Member

Thanks @rogermparent 👍

@shcheklein shcheklein merged commit ca302ec into master May 26, 2020
@shcheklein shcheklein deleted the re-add-abbrs-within-details branch June 30, 2020 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

glossary: tooltips break details sections
3 participants