Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove WebDAV as a remote option #1355

Closed
djwessel opened this issue May 25, 2020 · 3 comments · Fixed by #1356
Closed

remove WebDAV as a remote option #1355

djwessel opened this issue May 25, 2020 · 3 comments · Fixed by #1356
Labels
A: docs Area: user documentation (gatsby-theme-iterative) good first issue Good for newcomers help wanted Contributors especially welcome 🐛 type: bug Something isn't working.

Comments

@djwessel
Copy link

djwessel commented May 25, 2020 •
edited by jorgeorpinel
Loading

#1187 Added a reference to WebDAV support to the docs, however WebDAV is not yet supported iterative/dvc#1153

Context: https://discord.com/channels/485586884165107732/485596304961962003/714405205080539168
@shcheklein shcheklein changed the title Remove WebDAV as a remote option remove WebDAV as a remote option May 25, 2020
@shcheklein shcheklein added 🐛 type: bug Something isn't working. A: docs Area: user documentation (gatsby-theme-iterative) good first issue Good for newcomers help wanted Contributors especially welcome labels May 25, 2020
This was referenced May 25, 2020
Merged
Closed
jorgeorpinel added a commit that referenced this issue May 25, 2020
@jorgeorpinel
cmd ref: remove WebDAV remote info
3cfbf9b 
for #1355
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented May 25, 2020 •
edited
Loading

OK done in 3cfbf9b. We can just revert that commit to restore the WebDAV info later (and change back webdav:// to webdavs:// which was a wrong change in the previous commit).

shcheklein pushed a commit that referenced this issue May 25, 2020
@jorgeorpinel
Regular updates (May 25) (#1356)
d3a62b1 
* cmd ref: update WebDAV remote info
per #1187 (comment)

* cmd ref: remove WebDAV remote info
for #1355
@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented May 25, 2020 •
edited
Loading

So iterative/dvc/pull/3647 is merged but this isn't released @efiop? (assuming you know from Discord conversation.)

@efiop
Copy link
Contributor

efiop commented May 25, 2020

@jorgeorpinel That PR is not merged. Contributor closed it and promised to send a new one later. We can safely remove webdav from docs for now 🙁

shcheklein pushed a commit that referenced this issue May 26, 2020
@rogermparent @jorgeorpinel
Re-add abbrs within details (#1359)
ca302ec 
* cmd ref: update WebDAV remote info
per #1187 (comment)

* cmd ref: remove WebDAV remote info
for #1355

* glossary: add back DVC project
per #1334 (review)

* Re-add abbrs within details

This feature broke at some point in the past and all these were removed. The
feature has since been fixed, so these are safe to re-add.

* Re-add cache directory in add-files

* Change "cache directory" to "cache"

We don't have a tooltip match for "cache directory"

* Re-add some missed abbrs

* Revert grammar change

I think I missed the correct context originally when editing it, and committed
it because it looked like any other abbr addition.

Co-authored-by: Jorge Orpinel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: docs Area: user documentation (gatsby-theme-iterative) good first issue Good for newcomers help wanted Contributors especially welcome 🐛 type: bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Regular updates (May 25) iterative/dvc.org
4 participants
@jorgeorpinel @shcheklein @efiop @djwessel