Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uppercase REPO_TOKEN #489

Merged
merged 3 commits into from
Apr 29, 2021
Merged

uppercase REPO_TOKEN #489

merged 3 commits into from
Apr 29, 2021

Conversation

casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Apr 29, 2021

Because consistency with naming conventions is nice.

@casperdcl casperdcl marked this pull request as ready for review April 29, 2021 16:13
@0x2b3bfa0 0x2b3bfa0 changed the base branch from master to release/v0.3.7 April 29, 2021 16:14
Copy link
Contributor Author

@casperdcl casperdcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe document alternatives in just one place?

bin/cml-publish.test.js Outdated Show resolved Hide resolved
bin/cml-publish.js Outdated Show resolved Hide resolved
@0x2b3bfa0
Copy link
Member

Yes, it would be much better.

@0x2b3bfa0 0x2b3bfa0 merged commit cd1c875 into release/v0.3.7 Apr 29, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the REPO_TOKEN branch April 29, 2021 23:08
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Apr 29, 2021
0x2b3bfa0 added a commit that referenced this pull request Apr 29, 2021
* uppercase REPO_TOKEN

* document in one place

* Update snapshot tests

Co-authored-by: 0x2b3bfa0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants