-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.3.7 #488
Release v0.3.7 #488
Conversation
DavidGOrtega
commented
Apr 29, 2021
•
edited by 0x2b3bfa0
Loading
edited by 0x2b3bfa0
- test-cml-pr (test-cml-pr #487)
- chore: dependancron update dependencies (chore: dependancron update dependencies #481)
- docs: update README (some README updates #483 <- docs: make GHA default, docker optional #482)
- uppercase REPO_TOKEN (uppercase REPO_TOKEN #489)
This is for internal testing of |
0e41e4b
to
1763e1d
Compare
Co-authored-by: DavidGOrtega <[email protected]>
if (url) return render_pr(url); | ||
} else { | ||
try { | ||
await exec(`git config --local user.email "[email protected]"`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that this is because we don't have a dedicated bot account yet. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@0x2b3bfa0 yes. Thats not finished and actually the code is going to be reiterated. We are removing exec git in favour of an isomorphic git client.
This release is to test it in your side, checking possible scenarios that I might not have thought about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, thanks!
* some README updates - badges - more emphasis on setup-cml than docker * fix yaml -> bash - also prevents pre-commit hook from incorrectly reflowing * readme: update badge label * em-dash * readme: more copyedits * docs: more readme clarifications * better emoji support
* uppercase REPO_TOKEN * document in one place * Update snapshot tests Co-authored-by: 0x2b3bfa0 <[email protected]>