Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.3.7 #488

Merged
merged 5 commits into from
Apr 29, 2021
Merged

Release v0.3.7 #488

merged 5 commits into from
Apr 29, 2021

Conversation

DavidGOrtega
Copy link
Contributor

@DavidGOrtega DavidGOrtega commented Apr 29, 2021

@DavidGOrtega DavidGOrtega changed the title Release v0.3.7 Release v0.3.7 (#487) Apr 29, 2021
@DavidGOrtega DavidGOrtega requested a review from 0x2b3bfa0 April 29, 2021 11:33
@DavidGOrtega
Copy link
Contributor Author

This is for internal testing of test-cml-pr
I have to finish the diff report that we can also generate. Drawback is Bitbucket. Seems not to be supported.
Im still investigating.

if (url) return render_pr(url);
} else {
try {
await exec(`git config --local user.email "[email protected]"`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this is because we don't have a dedicated bot account yet. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x2b3bfa0 yes. Thats not finished and actually the code is going to be reiterated. We are removing exec git in favour of an isomorphic git client.
This release is to test it in your side, checking possible scenarios that I might not have thought about.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, thanks!

* some README updates

- badges
- more emphasis on setup-cml than docker

* fix yaml -> bash

- also prevents pre-commit hook from incorrectly reflowing

* readme: update badge label

* em-dash

* readme: more copyedits

* docs: more readme clarifications

* better emoji support
@casperdcl casperdcl linked an issue Apr 29, 2021 that may be closed by this pull request
* uppercase REPO_TOKEN

* document in one place

* Update snapshot tests

Co-authored-by: 0x2b3bfa0 <[email protected]>
@casperdcl casperdcl changed the title Release v0.3.7 (#487) Release v0.3.7 Apr 29, 2021
@0x2b3bfa0 0x2b3bfa0 merged commit 89d16b3 into master Apr 29, 2021
@0x2b3bfa0 0x2b3bfa0 deleted the release/v0.3.7 branch April 29, 2021 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: make GHA default, docker optional
3 participants